third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h - Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h

Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp ('k') | third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h

index 559f1b01a752cfd3ff5129536af5374fd0fbd0d4..5d79c949eb44965be90441656b1e1c4ad0125667 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h

+++ b/third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h

@@ -20,7 +20,7 @@ public:

virtual void runMessageLoopOnPause(int contextGroupId) = 0;

virtual void quitMessageLoopOnPause() = 0;

virtual void eventListeners(v8::Local<v8::Value>, EventListenerInfoMap&) = 0;

- virtual bool callingContextCanAccessContext(v8::Local<v8::Context>) = 0;

+ virtual bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) = 0;

virtual v8::MaybeLocal<v8::Value> callFunction(v8::Local<v8::Function>, v8::Local<v8::Context>, v8::Local<v8::Value> receiver, int argc, v8::Local<v8::Value> info[]) = 0;

};