Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1648343003: Consolidate SK_CRASH and sk_throw into SK_ABORT (Closed)

Created:
4 years, 10 months ago by djsollen
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -78 lines) Patch
M bench/ChecksumBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/nanobench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/textblob.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/config/SkUserConfig.h View 1 chunk +0 lines, -7 lines 0 comments Download
M include/core/SkPostConfig.h View 2 chunks +12 lines, -33 lines 0 comments Download
M include/core/SkTArray.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkTypes.h View 3 chunks +7 lines, -3 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRegionPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrAllocator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontMgr_win_dw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkMemory_malloc.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/ports/SkMemory_mozalloc.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ports/SkTypeface_win_dw.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CachedDataTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsCubicLineIntersectionIdeas.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M tools/Stats.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/sk_tool_utils_font.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
djsollen
4 years, 10 months ago (2016-01-29 16:13:40 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648343003/1
4 years, 10 months ago (2016-01-29 16:14:32 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-29 16:42:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648343003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648343003/1
4 years, 10 months ago (2016-01-29 16:50:27 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 16:51:08 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f2b340fc885ad2a12d2d73974eff9c8f4c94192c

Powered by Google App Engine
This is Rietveld 408576698