src/core/SkPath.cpp - Issue 1648343003: Consolidate SK_CRASH and sk_throw into SK_ABORT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPath.cpp

Issue 1648343003: Consolidate SK_CRASH and sk_throw into SK_ABORT (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPath.cpp

diff --git a/src/core/SkPath.cpp b/src/core/SkPath.cpp

index 400b7ab86ca9582bddf5a23f8897b837c21b0f5c..f3c2628c4fe33fe7449451de4225d4d1143e81ec 100644

--- a/src/core/SkPath.cpp

+++ b/src/core/SkPath.cpp

@@ -275,7 +275,7 @@ bool SkPath::conservativelyContainsRect(const SkRect& rect) const {

orig.set(pts, iter.conicWeight());

SkPoint quadPts[5];

int count = orig.chopIntoQuadsPOW2(quadPts, 1);

- SK_ALWAYSBREAK(2 == count);

+ SkASSERT_RELEASE(2 == count);

if (!check_edge_against_rect(quadPts[0], quadPts[2], rect, direction)) {

return false;

« no previous file with comments | « include/core/SkTypes.h ('k') | src/core/SkRegionPriv.h » ('j') | no next file with comments »