Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1648333002: [css-grid] Rename GridCoordinate to GridArea (Closed)

Created:
3 years, 3 months ago by Manuel Rego
Modified:
3 years, 3 months ago
Reviewers:
svillar, Timothy Loh, rune
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, svillar, blink-reviews-css, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, eae+blinkwatch, blink-reviews-layout_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Rename GridCoordinate to GridArea As the comment in GridCoordinate says, it actually represents a grid area as it stores the initial and final positions in both axis (columns and rows). Someone can think about a grid coordinate just like a single cell. However this class was representing an area of several cells. On top of that the "grid area" concept is defined in the spec: https://drafts.csswg.org/css-grid/#grid-area-concept No new tests, no change of behavior. BUG=444011 Committed: https://crrev.com/d2b19519116145ad2e1baa24a3965726dc0eabc6 Cr-Commit-Position: refs/heads/master@{#372638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -283 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSGridTemplateAreasValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSGridTemplateAreasValue.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.h View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 15 chunks +37 lines, -37 lines 0 comments Download
A + third_party/WebKit/Source/core/style/GridArea.h View 3 chunks +10 lines, -10 lines 0 comments Download
D third_party/WebKit/Source/core/style/GridCoordinate.h View 1 chunk +0 lines, -216 lines 0 comments Download
M third_party/WebKit/Source/core/style/GridPositionsResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleGridData.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Manuel Rego
Another small refactoring on grid placement code.
3 years, 3 months ago (2016-01-29 16:07:34 UTC) #2
rune
lgtm
3 years, 3 months ago (2016-02-01 09:44:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648333002/1
3 years, 3 months ago (2016-02-01 10:04:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 3 months ago (2016-02-01 11:21:45 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2016-02-01 11:23:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2b19519116145ad2e1baa24a3965726dc0eabc6
Cr-Commit-Position: refs/heads/master@{#372638}

Powered by Google App Engine
This is Rietveld 408576698