third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h - Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove fn to clear all main thread scrolling reasons Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp ('K') | « third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp ('k') | third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp » ('j') | third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

index 2f3892743f3102ab58a0e4825a12088469fd58cd..6e93dc234f03c5fe59e30195aa9d8c6c028fcc53 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

@@ -27,6 +27,8 @@ public:

bool hasAnimationThatRequiresService() const;

+ virtual bool hasRunningAnimation() const { return false; }

virtual void resetAnimationState();

virtual void cancelAnimation();

@@ -46,6 +48,9 @@ protected:

void removeAnimation();

void abortAnimation();

+ void addMainThreadScrollingReason();

+ void removeMainThreadScrollingReason();

void compositorAnimationFinished(int groupId);

void reattachCompositorPlayerIfNeeded(WebCompositorAnimationTimeline*);