Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h

Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: skip irrelevant test on mac Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h
index b2300f4cf5e8f1815895e98e920bc96a2608a722..55018f488d6e0a457608200edb21434ed8b447b5 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h
+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.h
@@ -31,6 +31,8 @@ public:
bool hasAnimationThatRequiresService() const;
void dispose();
+ virtual bool hasRunningAnimation() const { return false; }
+
virtual void resetAnimationState();
virtual void cancelAnimation();
@@ -51,7 +53,8 @@ protected:
void abortAnimation();
void compositorAnimationFinished(int groupId);
- void reattachCompositorPlayerIfNeeded(CompositorAnimationTimeline*);
+ // Returns true if the compositor player was attached to a new layer.
+ bool reattachCompositorPlayerIfNeeded(CompositorAnimationTimeline*);
// WebCompositorAnimationDelegate implementation.
void notifyAnimationStarted(double monotonicTime, int group) override;

Powered by Google App Engine
This is Rietveld 408576698