Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp

Issue 1648293003: Fix smooth scroll jump when switching scroll handling between MT and CC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: skip irrelevant test on mac Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp
index 3a90c1ec967b68053b78334e54f73bb9d9a61b1b..d35fe84952b0240996fbe3a25a88f098afe18104 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp
+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp
@@ -163,9 +163,10 @@ void ScrollAnimatorCompositorCoordinator::compositorAnimationFinished(
}
}
-void ScrollAnimatorCompositorCoordinator::reattachCompositorPlayerIfNeeded(
+bool ScrollAnimatorCompositorCoordinator::reattachCompositorPlayerIfNeeded(
CompositorAnimationTimeline* timeline)
{
+ bool reattached = false;
int compositorAnimationAttachedToLayerId = 0;
if (scrollableArea()->layerForScrolling())
compositorAnimationAttachedToLayerId = scrollableArea()->layerForScrolling()->platformLayer()->id();
@@ -184,10 +185,13 @@ void ScrollAnimatorCompositorCoordinator::reattachCompositorPlayerIfNeeded(
timeline->playerAttached(*this);
m_compositorPlayer->attachLayer(
scrollableArea()->layerForScrolling()->platformLayer());
+ reattached = true;
}
m_compositorAnimationAttachedToLayerId = compositorAnimationAttachedToLayerId;
}
}
+
+ return reattached;
}
void ScrollAnimatorCompositorCoordinator::notifyAnimationStarted(

Powered by Google App Engine
This is Rietveld 408576698