Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 164823005: Long press menu (shift+f6) to toggle spoken feedback. (Closed)

Created:
6 years, 10 months ago by oshima
Modified:
6 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Long press menu (shift+f6) to toggle spoken feedback. Factor out KeyHoldDetector. BUG=343277 TEST=SpokenFeedbackTogglerTest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251490

Patch Set 1 : #

Total comments: 11

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -399 lines) Patch
A ash/accelerators/key_hold_detector.h View 1 1 chunk +71 lines, -0 lines 0 comments Download
A + ash/accelerators/key_hold_detector.cc View 1 4 chunks +11 lines, -59 lines 0 comments Download
A ash/accelerators/magnifier_key_scroller.h View 1 1 chunk +55 lines, -0 lines 0 comments Download
A ash/accelerators/magnifier_key_scroller.cc View 1 1 chunk +81 lines, -0 lines 0 comments Download
A + ash/accelerators/magnifier_key_scroller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A ash/accelerators/spoken_feedback_toggler.h View 1 1 chunk +57 lines, -0 lines 0 comments Download
A ash/accelerators/spoken_feedback_toggler.cc View 1 1 chunk +58 lines, -0 lines 0 comments Download
A ash/accelerators/spoken_feedback_toggler_unittest.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M ash/ash.gyp View 1 2 3 4 6 chunks +16 lines, -6 lines 0 comments Download
D ash/magnifier/magnifier_key_scroller.h View 1 1 chunk +0 lines, -67 lines 0 comments Download
D ash/magnifier/magnifier_key_scroller.cc View 1 1 chunk +0 lines, -146 lines 0 comments Download
D ash/magnifier/magnifier_key_scroller_unittest.cc View 1 1 chunk +0 lines, -111 lines 0 comments Download
M ash/shell.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 3 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
oshima
6 years, 10 months ago (2014-02-14 00:46:37 UTC) #1
xiyuan
LGTM https://codereview.chromium.org/164823005/diff/90001/ash/accelerators/key_hold_detector.cc File ash/accelerators/key_hold_detector.cc (right): https://codereview.chromium.org/164823005/diff/90001/ash/accelerators/key_hold_detector.cc#newcode90 ash/accelerators/key_hold_detector.cc:90: // controller->SetScrollDirection(MagnificationController::SCROLL_NONE); nit: remove this? https://codereview.chromium.org/164823005/diff/90001/ash/accelerators/key_hold_detector.h File ash/accelerators/key_hold_detector.h ...
6 years, 10 months ago (2014-02-14 01:50:21 UTC) #2
oshima
I moved magnifier_key_scroller to ash/accelerator to be more consistent. PTAL. https://codereview.chromium.org/164823005/diff/90001/ash/accelerators/key_hold_detector.cc File ash/accelerators/key_hold_detector.cc (right): https://codereview.chromium.org/164823005/diff/90001/ash/accelerators/key_hold_detector.cc#newcode90 ...
6 years, 10 months ago (2014-02-14 18:03:24 UTC) #3
xiyuan
LGTM++
6 years, 10 months ago (2014-02-14 18:06:46 UTC) #4
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 10 months ago (2014-02-14 18:07:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/164823005/200001
6 years, 10 months ago (2014-02-14 18:07:39 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 18:51:38 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 10 months ago (2014-02-14 18:51:39 UTC) #8
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 10 months ago (2014-02-14 19:33:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/164823005/560001
6 years, 10 months ago (2014-02-14 19:34:56 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 20:55:42 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=202442
6 years, 10 months ago (2014-02-14 20:55:43 UTC) #12
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 10 months ago (2014-02-15 00:20:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/164823005/560001
6 years, 10 months ago (2014-02-15 00:35:02 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 03:21:09 UTC) #15
Message was sent while issue was closed. 
Change committed as 251490

Powered by Google App Engine
This is Rietveld 408576698