Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1648123002: Fix narrowing warning in battor_sample_converter_unittest (Closed)

Created:
4 years, 10 months ago by scottmg
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix narrowing warning in battor_sample_converter_unittest On VS2015: d:\src\cr3\src\tools\battor_agent\battor_sample_converter_unittest.cc(28): error C2397: conversion from 'double' to 'int16_t' requires a narrowing conversion R=brucedawson@chromium.org, charliea@chromium.org BUG=440500 Committed: https://crrev.com/5911df8c175be2371f8907018a8c673120581912 Cr-Commit-Position: refs/heads/master@{#372227}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/battor_agent/battor_sample_converter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
scottmg
4 years, 10 months ago (2016-01-28 23:43:18 UTC) #3
brucedawson
Good catch. I like it when the new compiler warnings catch code that would be ...
4 years, 10 months ago (2016-01-29 00:08:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648123002/1
4 years, 10 months ago (2016-01-29 00:11:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 00:46:33 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 00:47:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5911df8c175be2371f8907018a8c673120581912
Cr-Commit-Position: refs/heads/master@{#372227}

Powered by Google App Engine
This is Rietveld 408576698