Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1648023002: Pass along Blink's visual rect for display items. (Closed)

Created:
4 years, 10 months ago by wkorman
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass along Blink's visual rect for display items. Resubmit of http://crrev.com/1518223002 now that we have a fix in for http://crbug.com/569643. Work still pending per http://crbug.com/569211 to use correct rects for certain items. BUG=529938 TBR=christr Committed: https://crrev.com/cb707057e21ac35d4fa5cb7fda268e4f9f6d1dff Cr-Commit-Position: refs/heads/master@{#372201}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 13 (6 generated)
wkorman
4 years, 10 months ago (2016-01-28 20:00:23 UTC) #2
wkorman
This was approved previously and is just a resubmit.
4 years, 10 months ago (2016-01-28 21:14:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648023002/1
4 years, 10 months ago (2016-01-28 21:15:58 UTC) #7
pdr.
LGTM https://codereview.chromium.org/1648023002/diff/1/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp File third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp (right): https://codereview.chromium.org/1648023002/diff/1/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp#newcode101 third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp:101: displayItem.appendToWebDisplayItemList(visualRect, list); Mind wrapping this all up in ...
4 years, 10 months ago (2016-01-28 23:07:45 UTC) #9
pdr.
On 2016/01/28 at 23:07:45, pdr wrote: > LGTM > > https://codereview.chromium.org/1648023002/diff/1/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp > File third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp (right): ...
4 years, 10 months ago (2016-01-28 23:08:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 23:14:09 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 23:15:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb707057e21ac35d4fa5cb7fda268e4f9f6d1dff
Cr-Commit-Position: refs/heads/master@{#372201}

Powered by Google App Engine
This is Rietveld 408576698