third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp - Issue 1648023002: Pass along Blink's visual rect for display items.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp

Issue 1648023002: Pass along Blink's visual rect for display items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "platform/graphics/paint/PaintArtifact.h"	5 #include "platform/graphics/paint/PaintArtifact.h"

6	6

7 #include "platform/TraceEvent.h"	7 #include "platform/TraceEvent.h"

8 #include "platform/geometry/IntRect.h"	8 #include "platform/geometry/IntRect.h"

9 #include "platform/graphics/paint/DrawingDisplayItem.h"	9 #include "platform/graphics/paint/DrawingDisplayItem.h"

10 #include "third_party/skia/include/core/SkRegion.h"	10 #include "third_party/skia/include/core/SkRegion.h"

(...skipping 79 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
90 displayItem.replay(graphicsContext);	90 displayItem.replay(graphicsContext);

91 }	91 }

92	92

93 void PaintArtifact::appendToWebDisplayItemList(WebDisplayItemList* list) const	93 void PaintArtifact::appendToWebDisplayItemList(WebDisplayItemList* list) const

94 {	94 {

95 TRACE_EVENT0("blink,benchmark", "PaintArtifact::appendToWebDisplayItemList") ;	95 TRACE_EVENT0("blink,benchmark", "PaintArtifact::appendToWebDisplayItemList") ;

96 #if ENABLE(ASSERT)	96 #if ENABLE(ASSERT)

97 m_displayItemList.assertDisplayItemClientsAreAlive();	97 m_displayItemList.assertDisplayItemClientsAreAlive();

98 #endif	98 #endif

99 for (const DisplayItem& displayItem : m_displayItemList) {	99 for (const DisplayItem& displayItem : m_displayItemList) {

100 // TODO(wkorman): Pass the actual visual rect for the display item.	100 IntRect visualRect = displayItem.client().visualRect();

101 displayItem.appendToWebDisplayItemList(IntRect(), list);	101 displayItem.appendToWebDisplayItemList(visualRect, list);
	pdr. 2016/01/28 23:07:45 Mind wrapping this all up in one line? for (const Mind wrapping this all up in one line? for (const DisplayItem& displayItem : m_displayItemList) displayItem.appendToWebDisplayItemList(displayItem.client().visualRect(), list);
102 }	102 }

103 }	103 }

104	104

105 } // namespace blink	105 } // namespace blink

OLD	NEW