Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 164793002: Small fixes for auto generating Android.mk (Closed)

Created:
6 years, 10 months ago by scroggo
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@skia_android_framework
Visibility:
Public.

Description

Small fixes for auto generating Android.mk Turn off -Wno-c++11-extensions for Android. The Android framework does not support this flag. Using it gives a bunch of warnings when building, so remove it. Remove skia_chrome_utils from framework. They are experimental and not used by Android. BUG=skia:1975 Committed: http://code.google.com/p/skia/source/detail?r=13475

Patch Set 1 #

Patch Set 2 : Re upload #

Total comments: 1

Patch Set 3 : Remove Android.mk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +6 lines, -1 line 0 comments Download
M gyp/common_variables.gypi View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
scroggo
https://codereview.chromium.org/164793002/diff/50001/Android.mk File Android.mk (left): https://codereview.chromium.org/164793002/diff/50001/Android.mk#oldcode61 Android.mk:61: -Wno-c++11-extensions \ This isn't checked in, but I tracked ...
6 years, 10 months ago (2014-02-13 21:26:14 UTC) #1
djsollen
lgtm. As a side note, I think we should look at rolling these 2 CLs ...
6 years, 10 months ago (2014-02-13 21:32:09 UTC) #2
scroggo
On 2014/02/13 21:32:09, djsollen wrote: > lgtm. As a side note, I think we should ...
6 years, 10 months ago (2014-02-13 21:35:13 UTC) #3
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 10 months ago (2014-02-17 14:08:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/164793002/50001
6 years, 10 months ago (2014-02-17 14:09:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-17 14:09:03 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Android.mk: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
6 years, 10 months ago (2014-02-17 14:09:03 UTC) #7
scroggo
On 2014/02/17 14:09:03, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 10 months ago (2014-02-17 14:23:34 UTC) #8
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 10 months ago (2014-02-17 14:23:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/164793002/150001
6 years, 10 months ago (2014-02-17 14:23:41 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-17 15:22:30 UTC) #11
Message was sent while issue was closed.
Change committed as 13475

Powered by Google App Engine
This is Rietveld 408576698