Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: gyp/common_conditions.gypi

Issue 164793002: Small fixes for auto generating Android.mk (Closed) Base URL: https://skia.googlesource.com/skia.git@skia_android_framework
Patch Set: Remove Android.mk Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index fb97bb2faff177960ca96fc5a761471c9b52fd51..48f8e19d033e07e740b03382908699b0657ea517 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -130,13 +130,18 @@
'-Wpointer-arith',
'-Wno-unused-parameter',
- '-Wno-c++11-extensions',
],
'cflags_cc': [
'-fno-rtti',
'-Wnon-virtual-dtor',
],
'conditions': [
+ [ 'skia_android_framework==0', {
+ 'cflags': [
+ # This flag is not supported by Android build system.
+ '-Wno-c++11-extensions',
+ ],
+ }],
[ 'skia_warnings_as_errors', {
'cflags': [
'-Werror',
« no previous file with comments | « no previous file | gyp/common_variables.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698