content/renderer/media/media_stream_audio_processor.h - Issue 1647773002: MediaStream audio sourcing: Bypass audio processing for non-WebRTC cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_audio_processor.h

Issue 1647773002: MediaStream audio sourcing: Bypass audio processing for non-WebRTC cases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/common/media_stream_request.h ('K') | « content/renderer/media/audio_track_recorder.cc ('k') | content/renderer/media/media_stream_audio_processor.cc » ('j') | content/renderer/media/media_stream_audio_source.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_audio_processor.h

diff --git a/content/renderer/media/media_stream_audio_processor.h b/content/renderer/media/media_stream_audio_processor.h

index dabc42f291c5356181b0d22c5f31890b6551fa96..80a8705b5046db131b59c7c138c1393999bc2a52 100644

--- a/content/renderer/media/media_stream_audio_processor.h

+++ b/content/renderer/media/media_stream_audio_processor.h

@@ -110,6 +110,15 @@ class CONTENT_EXPORT MediaStreamAudioProcessor :

void OnDisableAecDump() override;

void OnIpcClosing() override;

+ // Returns true if there are constraints or effects flags set to indicate that

+ // audio needs to be processed by MediaStreamAudioProcessor. Returns false if

+ // audio data should be directly delivered, unmodified, to all media stream

+ // sinks. See media::AudioParameters::PlatformEffectsMask for interpretation

+ // of |effects_flags|.

+ static bool ShouldRouteAudioThroughProcessor(

+ const blink::WebMediaConstraints& constraints,

+ int effects_flags);

protected:

~MediaStreamAudioProcessor() override;