content/renderer/media/audio_track_recorder.cc - Issue 1647773002: MediaStream audio sourcing: Bypass audio processing for non-WebRTC cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/audio_track_recorder.cc

Issue 1647773002: MediaStream audio sourcing: Bypass audio processing for non-WebRTC cases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/common/media_stream_request.h ('K') | « content/public/renderer/media_stream_api.cc ('k') | content/renderer/media/media_stream_audio_processor.h » ('j') | content/renderer/media/media_stream_audio_source.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/audio_track_recorder.cc

diff --git a/content/renderer/media/audio_track_recorder.cc b/content/renderer/media/audio_track_recorder.cc

index 05107b1257cbdec9cac88b965f08b24c99509faa..934c1b13e76864407db5e1deb266c487545220dd 100644

--- a/content/renderer/media/audio_track_recorder.cc

+++ b/content/renderer/media/audio_track_recorder.cc

@@ -10,6 +10,7 @@

#include "base/bind.h"

#include "base/macros.h"

#include "base/stl_util.h"

+#include "content/renderer/media/media_stream_audio_track.h"

#include "media/audio/audio_parameters.h"

#include "media/base/audio_bus.h"

#include "media/base/bind_to_current_loop.h"

@@ -275,7 +276,7 @@ AudioTrackRecorder::AudioTrackRecorder(

encoder_thread_("AudioEncoderThread") {

DCHECK(main_render_thread_checker_.CalledOnValidThread());

DCHECK(!track_.isNull());

- DCHECK(track_.extraData());

+ DCHECK(MediaStreamAudioTrack::GetTrack(track_));

// Start the |encoder_thread_|. From this point on, |encoder_| should work

// only on |encoder_thread_|, as enforced by DCHECKs.