rewrite_to_chrome_style: Don't rename begin()/end()/rbegin()/rend().

rewrite_to_chrome_style: Don't rename begin()/end()/rbegin()/rend().

These methods need their names to be lowercase for STL use and for
range-based for loops to work.

R=dcheng
BUG=581566
Committed: https://crrev.com/14026e46f2bdc97b035a452c7d73bc8a51ff0a81
Cr-Commit-Position: refs/heads/master@{#372174}

[danakj, 2016-01-28 01:07:11]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-28 01:08:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1647763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1647763002/40001

[commit-bot: I haz the power, 2016-01-28 02:14:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 02:14:31]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-01-28 06:58:12]

https://codereview.chromium.org/1647763002/diff/40001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1647763002/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:67: static const
std::string kBlacklist[] = {"begin", "end", "rbegin",
Did you see trace() getting renamed to Trace() in any of the diffs? That could
be another problematic one.

Also, how about:
static const char* kBlacklist[] = { ... };

https://codereview.chromium.org/1647763002/diff/40001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/tests/functions-original.cc (right):

https://codereview.chromium.org/1647763002/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/tests/functions-original.cc:20: void begin()
{}
Hopefully there are no uses of non-member begin() / end() in Blink.

[danakj, 2016-01-28 19:47:58]

PTAL

https://codereview.chromium.org/1647763002/diff/40001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1647763002/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:67: static const
std::string kBlacklist[] = {"begin", "end", "rbegin",
On 2016/01/28 06:58:12, dcheng wrote:
> Did you see trace() getting renamed to Trace() in any of the diffs? That could
> be another problematic one.
> 
> Also, how about:
> static const char* kBlacklist[] = { ... };

Oh, sure, char* it is.

https://codereview.chromium.org/1647763002/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:67: static const
std::string kBlacklist[] = {"begin", "end", "rbegin",
On 2016/01/28 06:58:12, dcheng wrote:
> Did you see trace() getting renamed to Trace() in any of the diffs? That could
> be another problematic one.

fun:trace:Trace

Ya, I'll add it.

> Also, how about:
> static const char* kBlacklist[] = { ... };

https://codereview.chromium.org/1647763002/diff/40001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/tests/functions-original.cc (right):

https://codereview.chromium.org/1647763002/diff/40001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/tests/functions-original.cc:20: void begin()
{}
On 2016/01/28 06:58:12, dcheng wrote:
> Hopefully there are no uses of non-member begin() / end() in Blink.

Ya, but better safe than sorry? :)

[danakj, 2016-01-28 19:48:08]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-28 19:49:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1647763002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1647763002/60001

[commit-bot: I haz the power, 2016-01-28 20:10:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 20:10:41]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-01-28 20:20:33]

lgtm

https://codereview.chromium.org/1647763002/diff/60001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1647763002/diff/60001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:64: if (const auto*
method = clang::dyn_cast<const clang::CXXMethodDecl>(&decl)) {
Nit: dyn_cast<clang::CXXMethodDecl> should work.

[danakj, 2016-01-28 21:26:38]

https://codereview.chromium.org/1647763002/diff/60001/tools/clang/rewrite_to_...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (right):

https://codereview.chromium.org/1647763002/diff/60001/tools/clang/rewrite_to_...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:64: if (const auto*
method = clang::dyn_cast<const clang::CXXMethodDecl>(&decl)) {
On 2016/01/28 20:20:33, dcheng wrote:
> Nit: dyn_cast<clang::CXXMethodDecl> should work.

Nope..

[danakj, 2016-01-28 21:26:42]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-01-28 21:27:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1647763002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1647763002/60001

[commit-bot: I haz the power, 2016-01-28 21:36:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-28 21:38:08]

Description was changed from

==========
rewrite_to_chrome_style: Don't rename begin()/end()/rbegin()/rend().

These methods need their names to be lowercase for STL use and for
range-based for loops to work.

R=dcheng
BUG=581566
==========

to

==========
rewrite_to_chrome_style: Don't rename begin()/end()/rbegin()/rend().

These methods need their names to be lowercase for STL use and for
range-based for loops to work.

R=dcheng
BUG=581566

Committed: https://crrev.com/14026e46f2bdc97b035a452c7d73bc8a51ff0a81
Cr-Commit-Position: refs/heads/master@{#372174}
==========

[commit-bot: I haz the power, 2016-01-28 21:38:09]

Patchset 4 (id:??) landed as
https://crrev.com/14026e46f2bdc97b035a452c7d73bc8a51ff0a81
Cr-Commit-Position: refs/heads/master@{#372174}