rewrite_to_chrome_style: Don't rename begin()/end()/rbegin()/rend().

tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Changes Blink-style names to Chrome-style names. Currently transforms:
 //   fields:
 //     int m_operationCount => int operation_count_
 //   variables (including parameters):
 //     int mySuperVariable => int my_super_variable
 //   constants:
@@ skipping 42 matching lines @@
   return Node.isOverloadedOperator();
 }
 
 constexpr char kBlinkFieldPrefix[] = "m_";
 constexpr char kBlinkStaticMemberPrefix[] = "s_";
 
 bool GetNameForDecl(const clang::FunctionDecl& decl,
                     const clang::ASTContext& context,
                     std::string& name) {
   name = decl.getNameAsString();
+
+  if (const auto* method = clang::dyn_cast<const clang::CXXMethodDecl>(&decl)) {

[dcheng, 2016/01/28 20:20:33]

Nit: dyn_cast<clang::CXXMethodDecl> should work.

[danakj, 2016/01/28 21:26:38]

Nope..

+    if (!method->isStatic()) {
+      // Some methods shouldn't be renamed because reasons.
+      static const char* kBlacklist[] = {"begin", "end", "rbegin", "rend",
+                                         "trace"};
+      for (const auto& b : kBlacklist) {
+        if (name == b)
+          return false;
+      }
+    }
+  }
+
   name[0] = clang::toUppercase(name[0]);
   return true;
 }
 
 // Helper to convert from a camelCaseName to camel_case_name. It uses some
 // heuristics to try to handle acronyms in camel case names correctly.
 std::string CamelCaseToUnderscoreCase(StringRef input) {
   std::string output;
   bool needs_underscore = false;
   bool was_lowercase = false;
@@ skipping 482 matching lines @@
   for (const auto& r : replacements) {
     std::string replacement_text = r.getReplacementText().str();
     std::replace(replacement_text.begin(), replacement_text.end(), '\n', '\0');
     llvm::outs() << "r:::" << r.getFilePath() << ":::" << r.getOffset()
                  << ":::" << r.getLength() << ":::" << replacement_text << "\n";
   }
   llvm::outs() << "==== END EDITS ====\n";
 
   return 0;
 }