Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 164773005: Pull GN @ 252040, update calls (Closed)

Created:
6 years, 10 months ago by brettw
Modified:
6 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Pull GN @ 252040, update calls Updates all rebase_path calls to use the new parameter ordering. Use the new getenv function and delete the Python script we had to get the home directory. Takes advantage of the new ability to have the default value of declare_args blocks be dependent on other values. This simplifies some code. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252065

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : pull new binary #

Patch Set 5 : long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -157 lines) Patch
M build/config/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/config.gni View 1 2 2 chunks +10 lines, -14 lines 0 comments Download
M build/config/arm.gni View 1 2 3 4 1 chunk +45 lines, -42 lines 0 comments Download
M build/config/clang/BUILD.gn View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M build/config/ios/ios_sdk.gni View 1 2 1 chunk +9 lines, -14 lines 0 comments Download
M build/config/linux/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/config/sysroot.gni View 1 chunk +4 lines, -5 lines 0 comments Download
M build/config/ui.gni View 1 chunk +6 lines, -28 lines 0 comments Download
M build/toolchain/clang.gni View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
D build/toolchain/get_default_posix_goma_dir.py View 1 chunk +0 lines, -11 lines 0 comments Download
M build/toolchain/goma.gni View 1 chunk +6 lines, -9 lines 0 comments Download
M build/toolchain/linux/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 2 chunks +5 lines, -3 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/util/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/bin/linux/gn.sha1 View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/linux/gn32.sha1 View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/mac/gn.sha1 View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/bin/win/gn.exe.sha1 View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/function_exec_script.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/gn/secondary/chrome/BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/secondary/device/usb/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/secondary/tools/grit/grit_rule.gni View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/gn/variables.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
This will incorporate a GN binary push once https://codereview.chromium.org/161783002/ is landed.
6 years, 10 months ago (2014-02-14 23:30:41 UTC) #1
scottmg
lgtm
6 years, 10 months ago (2014-02-14 23:55:35 UTC) #2
brettw
6 years, 10 months ago (2014-02-19 20:32:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r252065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698