Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2779)

Unified Diff: build/config/ui.gni

Issue 164773005: Pull GN @ 252040, update calls (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: long line Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/sysroot.gni ('k') | build/toolchain/clang.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ui.gni
diff --git a/build/config/ui.gni b/build/config/ui.gni
index b9969c06e36a4ca6707e32791b90ba67aa04ea94..08964df8701dcbcc83c0bb726400583c61cf6bcc 100644
--- a/build/config/ui.gni
+++ b/build/config/ui.gni
@@ -10,42 +10,20 @@
# e.g. base, so they need to be global.
declare_args() {
- # True means the UI is built useing the "views" framework.
- toolkit_views = false
-
# Indicates if Ash is enabled. Ash is the Aura SHell which provides a
# desktop-like environment for Aura. Requires use_aura = true
- use_ash = false
-
- # Indicates if Aura is enabled. Aura is a low-level windowing library, sort
- # of a replacement for GDI or GTK.
- use_aura = false
+ use_ash = is_win || is_chromeos
# Indicates if Ozone is enabled. Ozone is a low-level library layer for Linux
# that does not require X11.
use_ozone = false
-}
-
-if (is_win || is_chromeos) {
- # Windows currelty implies Aura.
- # TODO(brettw) bug 342937 move to declare_args block.
- use_ash = true
- use_aura = true
-}
-
-if (is_linux || use_ozone) {
- use_aura = true
-}
-if (!use_aura) {
- use_ash = false # Ash needs Aura.
-}
+ # Indicates if Aura is enabled. Aura is a low-level windowing library, sort
+ # of a replacement for GDI or GTK.
+ use_aura = is_linux || use_ozone || is_win || is_chromeos || use_ash
-# TODO(brettw) bug 342937 move this to the declare_args block above when this
-# is supported. It would look like:
-# toolkit_views = is_win || is_chromeos || use_aura
-if (is_win || is_chromeos || use_aura) {
- toolkit_views = true
+ # True means the UI is built useing the "views" framework.
+ toolkit_views = is_win || is_chromeos || use_aura
}
# Additional dependent variables -----------------------------------------------
« no previous file with comments | « build/config/sysroot.gni ('k') | build/toolchain/clang.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698