Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1752)

Issue 1647653008: Don't silently swallow error about symbolize script not existing. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't silently swallow error about symbolize script not existing. Depends on https://codereview.chromium.org/1645183003/ BUG=582457 Committed: https://crrev.com/45643b4edeae3fb60ca98b3c4f9043a5040b0179 Cr-Commit-Position: refs/heads/master@{#372431}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M testing/test_env.py View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Nico
4 years, 10 months ago (2016-01-29 16:30:05 UTC) #3
M-A Ruel
lgtm with optional changes. https://codereview.chromium.org/1647653008/diff/1/testing/test_env.py File testing/test_env.py (right): https://codereview.chromium.org/1647653008/diff/1/testing/test_env.py#newcode158 testing/test_env.py:158: print 'Exception while symbolizing snippets: ...
4 years, 10 months ago (2016-01-29 16:34:23 UTC) #4
Nico
dpranke for testing/OWNERS
4 years, 10 months ago (2016-01-29 20:01:25 UTC) #6
Dirk Pranke
lgtm w/ maruel's corrections.
4 years, 10 months ago (2016-01-29 20:14:49 UTC) #7
Nico
done, thanks
4 years, 10 months ago (2016-01-29 20:20:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647653008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647653008/20001
4 years, 10 months ago (2016-01-29 20:22:15 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-29 21:53:50 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 21:55:25 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/45643b4edeae3fb60ca98b3c4f9043a5040b0179
Cr-Commit-Position: refs/heads/master@{#372431}

Powered by Google App Engine
This is Rietveld 408576698