Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1579)

Unified Diff: testing/test_env.py

Issue 1647653008: Don't silently swallow error about symbolize script not existing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/test_env.py
diff --git a/testing/test_env.py b/testing/test_env.py
index 0513e1a0fd96c2d1dc58e3eb3128ee96651a5e7d..7d72169d235d63189df04dcb037c78eb5fa70b9e 100755
--- a/testing/test_env.py
+++ b/testing/test_env.py
@@ -156,11 +156,13 @@ def symbolize_snippets_in_json(cmd, env):
p = subprocess.Popen(symbolize_command, stderr=subprocess.PIPE, env=env)
(_, stderr) = p.communicate()
except OSError as e:
- print 'Exception while symbolizing snippets: %s' % e
+ print >> sys.stderr, 'Exception while symbolizing snippets: %s' % e
+ raise
if p.returncode != 0:
- print "Error: failed to symbolize snippets in JSON:\n"
- print stderr
+ print >> sys.stderr, "Error: failed to symbolize snippets in JSON:\n"
+ print >> sys.stderr, stderr
+ raise subprocess.CalledProcessError(p.returncode, symbolize_command)
def run_executable(cmd, env):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698