Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1647583003: Revert of [Template Expressions] changing ${ leader to $i18n{ (Closed)

Created:
4 years, 11 months ago by Dan Beam
Modified:
4 years, 11 months ago
Reviewers:
dschuyler, Nico
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Template Expressions] changing ${ leader to $i18n{ (patchset #4 id:60001 of https://codereview.chromium.org/1585923011/ ) Reason for revert: broke incognito NTP and chrome://apps https://code.google.com/p/chromium/issues/detail?id=581621 Original issue's description: > [Template Expressions] changing ${ leader to $i18n{ > > This CL changes the Template Expressions from using > a ${ to identify the start of an expression, to using > $i18n{. The intention is to reduce (eliminate) false > positives when searching for expressions that need > replacement. This CL also prepares for the replacement > work to be done in a background thread and used on a > broader set of files. > > BUG=506009 > > Committed: https://crrev.com/5aa7fd5f14e49c65ebba87e4248424d622b92930 > Cr-Commit-Position: refs/heads/master@{#371537} TBR=thakis@chromium.org,dschuyler@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=506009 Committed: https://crrev.com/28e39abf4baf1b29c199659f8ef2a48f1df68329 Cr-Commit-Position: refs/heads/master@{#371888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -72 lines) Patch
M chrome/browser/resources/ntp4/new_incognito_tab_theme.css View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab_theme.css View 2 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/web_dev_style/css_checker.py View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/template_expressions.h View 1 chunk +1 line, -4 lines 0 comments Download
M ui/base/template_expressions.cc View 1 chunk +8 lines, -15 lines 0 comments Download
M ui/base/template_expressions_unittest.cc View 1 chunk +11 lines, -10 lines 0 comments Download
M ui/base/webui/web_ui_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/css/text_defaults.css View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Dan Beam
Created Revert of [Template Expressions] changing ${ leader to $i18n{
4 years, 11 months ago (2016-01-27 20:33:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1647583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1647583003/1
4 years, 11 months ago (2016-01-27 20:44:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 22:12:51 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 22:13:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28e39abf4baf1b29c199659f8ef2a48f1df68329
Cr-Commit-Position: refs/heads/master@{#371888}

Powered by Google App Engine
This is Rietveld 408576698