chrome/browser/web_dev_style/css_checker.py - Issue 1647583003: Revert of [Template Expressions] changing ${ leader to $i18n{

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_dev_style/css_checker.py

Issue 1647583003: Revert of [Template Expressions] changing ${ leader to $i18n{ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/web_dev_style/css_checker.py

diff --git a/chrome/browser/web_dev_style/css_checker.py b/chrome/browser/web_dev_style/css_checker.py

index 7d03a60feb8bd7b846cc94ed52edaa50beb03e2a..3713561e5e129acc137b5a5bc8f790624a62d3b0 100644

--- a/chrome/browser/web_dev_style/css_checker.py

+++ b/chrome/browser/web_dev_style/css_checker.py

@@ -1,4 +1,4 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

@@ -52,7 +52,7 @@

return re.sub(re.compile(r'--[\d\w-]+: {.*?};', re.DOTALL), '', s)

def _remove_template_expressions(s):

- return re.sub(re.compile(r'\$i18n{[^}]*}', re.DOTALL), '', s)

+ return re.sub(re.compile(r'\${[^}]*}', re.DOTALL), '', s)

def _remove_grit(s):

grit_reg = re.compile(r"""

« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_resource_cache.cc ('k') | ui/base/template_expressions.h » ('j') | no next file with comments »