Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: build/android/gyp/strip_library_for_device.py

Issue 1647353002: Use gn_helpers to [se]serialize GN lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@python_impl
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/insert_chromium_version.py ('k') | build/android/gyp/util/build_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/strip_library_for_device.py
diff --git a/build/android/gyp/strip_library_for_device.py b/build/android/gyp/strip_library_for_device.py
index 9e2daae33acfa057f23eb2c53b1cd6ed47c9bfb5..7b3da44b3a1ebf27c6ac3b59e9a23d062ccbd37b 100755
--- a/build/android/gyp/strip_library_for_device.py
+++ b/build/android/gyp/strip_library_for_device.py
@@ -4,6 +4,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import ast
import optparse
import os
import sys
@@ -32,14 +33,14 @@ def main(args):
parser.add_option('--libraries-dir',
help='Directory for un-stripped libraries')
parser.add_option('--stripped-libraries-dir',
- help='Directory for stripped libraries')
+ help='Directory for stripped libraries in JSON format')
parser.add_option('--libraries',
- help='List of libraries to strip')
+ help='List of libraries to strip in JSON format.')
parser.add_option('--stamp', help='Path to touch on success')
options, _ = parser.parse_args(args)
- libraries = build_utils.ParseGypList(options.libraries)
+ libraries = ast.literal_eval(options.libraries)
Dirk Pranke 2016/01/30 00:26:48 if this is in JSON format, why are you using liter
brettw 2016/01/30 05:48:22 Clarified to "Python dictionary format"
build_utils.MakeDirectory(options.stripped_libraries_dir)
« no previous file with comments | « build/android/gyp/insert_chromium_version.py ('k') | build/android/gyp/util/build_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698