Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: build/android/gyp/insert_chromium_version.py

Issue 1647353002: Use gn_helpers to [se]serialize GN lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@python_impl
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/gyp/insert_chromium_version.py
diff --git a/build/android/gyp/insert_chromium_version.py b/build/android/gyp/insert_chromium_version.py
index 171f9d41b8d1d70f281b6c5fb6a65c2d347e25fb..9fefa2314e59423bf7e5880190d4705412111307 100755
--- a/build/android/gyp/insert_chromium_version.py
+++ b/build/android/gyp/insert_chromium_version.py
@@ -7,6 +7,7 @@
"""Insert a version string into a library as a section '.chromium.version'.
"""
+import ast
import optparse
import os
import sys
@@ -41,13 +42,13 @@ def main(args):
parser.add_option('--stripped-libraries-dir',
help='Directory of native libraries')
parser.add_option('--libraries',
- help='List of libraries')
+ help='List of libraries in Python list format')
parser.add_option('--version-string',
help='Version string to be inserted')
parser.add_option('--stamp', help='Path to touch on success')
options, _ = parser.parse_args(args)
- libraries = build_utils.ParseGypList(options.libraries)
+ libraries = ast.literal_eval(options.libraries)
for library in libraries:
library_path = os.path.join(options.stripped_libraries_dir, library)
« no previous file with comments | « no previous file | build/android/gyp/strip_library_for_device.py » ('j') | build/android/gyp/strip_library_for_device.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698