Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Unified Diff: build/android/gyp/jar.py

Issue 1647353002: Use gn_helpers to [se]serialize GN lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@python_impl
Patch Set: more Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/insert_chromium_version.py ('k') | build/android/gyp/javac.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/jar.py
diff --git a/build/android/gyp/jar.py b/build/android/gyp/jar.py
index 438f4bb03813dcb11b6849786ab952f65edddabc..990b05b6c8081d97ef96f8179c1ee62ae2c2b5c6 100755
--- a/build/android/gyp/jar.py
+++ b/build/android/gyp/jar.py
@@ -77,9 +77,9 @@ def main():
parser.add_option('--input-jar', help='Jar to include .class files from')
parser.add_option('--jar-path', help='Jar output path.')
parser.add_option('--excluded-classes',
- help='GYP list of .class file patterns to exclude from the jar.')
+ help='GN list of .class file patterns to exclude from the jar.')
parser.add_option('--strip-resource-classes-for',
- help='GYP list of java package names exclude R.class files in.')
+ help='GN list of java package names exclude R.class files in.')
parser.add_option('--stamp', help='Path to touch on success.')
args = build_utils.ExpandFileArgs(sys.argv[1:])
@@ -89,10 +89,10 @@ def main():
excluded_classes = []
if options.excluded_classes:
- excluded_classes = build_utils.ParseGypList(options.excluded_classes)
+ excluded_classes = build_utils.ParseGnList(options.excluded_classes)
if options.strip_resource_classes_for:
- packages = build_utils.ParseGypList(options.strip_resource_classes_for)
+ packages = build_utils.ParseGnList(options.strip_resource_classes_for)
excluded_classes.extend(p.replace('.', '/') + '/' + f
for p in packages for f in _RESOURCE_CLASSES)
« no previous file with comments | « build/android/gyp/insert_chromium_version.py ('k') | build/android/gyp/javac.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698