Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3256)

Unified Diff: build/android/gyp/javac.py

Issue 1647353002: Use gn_helpers to [se]serialize GN lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@python_impl
Patch Set: more Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/jar.py ('k') | build/android/gyp/jinja_template.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/javac.py
diff --git a/build/android/gyp/javac.py b/build/android/gyp/javac.py
index c8425bd3aa578880d0b88f46440569c97670b589..9e5518af979b1c870c6456d78bb168145f0ca30a 100755
--- a/build/android/gyp/javac.py
+++ b/build/android/gyp/javac.py
@@ -314,17 +314,17 @@ def _ParseOptions(argv):
bootclasspath = []
for arg in options.bootclasspath:
- bootclasspath += build_utils.ParseGypList(arg)
+ bootclasspath += build_utils.ParseGnList(arg)
options.bootclasspath = bootclasspath
classpath = []
for arg in options.classpath:
- classpath += build_utils.ParseGypList(arg)
+ classpath += build_utils.ParseGnList(arg)
options.classpath = classpath
java_srcjars = []
for arg in options.java_srcjars:
- java_srcjars += build_utils.ParseGypList(arg)
+ java_srcjars += build_utils.ParseGnList(arg)
options.java_srcjars = java_srcjars
additional_jar_files = []
@@ -334,11 +334,11 @@ def _ParseOptions(argv):
options.additional_jar_files = additional_jar_files
if options.src_gendirs:
- options.src_gendirs = build_utils.ParseGypList(options.src_gendirs)
+ options.src_gendirs = build_utils.ParseGnList(options.src_gendirs)
- options.javac_includes = build_utils.ParseGypList(options.javac_includes)
+ options.javac_includes = build_utils.ParseGnList(options.javac_includes)
options.jar_excluded_classes = (
- build_utils.ParseGypList(options.jar_excluded_classes))
+ build_utils.ParseGnList(options.jar_excluded_classes))
java_files = []
for arg in args:
« no previous file with comments | « build/android/gyp/jar.py ('k') | build/android/gyp/jinja_template.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698