Add SkAndroidCodec::getPixels

Add SkAndroidCodec::getPixels

This is a synonym for the version of getAndroidPixels that accepts
only three parameters (i.e. no AndroidOptions). It is very similar
to SkCodec::getPixels, so I think the motivation for naming the
version with options differently does not apply here.

Add comments to the header describing defaults.

Update the test to use a template, and delete a lot of redundant code.

Rename a variable to stop shadowing another variable.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1647153002

Committed: https://skia.googlesource.com/skia/+/7b5e5536a18123f568afca99dc8f89019eab2c77

[scroggo, 2016-01-29 15:09:12]

Description was changed from

==========
Add SkAndroidCodec::getPixels

This is a synonym for the version of getAndroidPixels that accepts
only three parameters (i.e. no AndroidOptions). It is very similar
to SkCodec::getPixels, so I think the motivation for naming the
version with options differently does not apply here.

Update the test to use a template, and delete a lot of redundant code.
==========

to

==========
Add SkAndroidCodec::getPixels

This is a synonym for the version of getAndroidPixels that accepts
only three parameters (i.e. no AndroidOptions). It is very similar
to SkCodec::getPixels, so I think the motivation for naming the
version with options differently does not apply here.

Update the test to use a template, and delete a lot of redundant code.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-29 15:10:40]

Description was changed from

==========
Add SkAndroidCodec::getPixels

This is a synonym for the version of getAndroidPixels that accepts
only three parameters (i.e. no AndroidOptions). It is very similar
to SkCodec::getPixels, so I think the motivation for naming the
version with options differently does not apply here.

Update the test to use a template, and delete a lot of redundant code.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add SkAndroidCodec::getPixels

This is a synonym for the version of getAndroidPixels that accepts
only three parameters (i.e. no AndroidOptions). It is very similar
to SkCodec::getPixels, so I think the motivation for naming the
version with options differently does not apply here.

Update the test to use a template, and delete a lot of redundant code.

Rename a variable to stop shadowing another variable.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-29 15:10:54]

scroggo@google.com changed reviewers:
+ msarett@google.com, reed@google.com

[msarett, 2016-01-29 15:16:39]

lgtm

Great!

https://codereview.chromium.org/1647153002/diff/1/include/codec/SkAndroidCodec.h
File include/codec/SkAndroidCodec.h (right):

https://codereview.chromium.org/1647153002/diff/1/include/codec/SkAndroidCode...
include/codec/SkAndroidCodec.h:227: SkCodec::Result getAndroidPixels(const
SkImageInfo& info, void* pixels, size_t rowBytes);
Thoughts on also naming this getPixels() (not in this CL)?

I realize it's my fault that there is Android in the name.

Same question for AndroidOptions.

[reed1, 2016-01-29 17:05:34]

https://codereview.chromium.org/1647153002/diff/1/include/codec/SkAndroidCodec.h
File include/codec/SkAndroidCodec.h (right):

https://codereview.chromium.org/1647153002/diff/1/include/codec/SkAndroidCode...
include/codec/SkAndroidCodec.h:222: *  Simplified version of getAndroidPixels()
where we supply the default AndroidOptions.
What are the "default" options?
What if I pass null to the first version?

[scroggo, 2016-01-29 19:50:22]

Description was changed from

==========
Add SkAndroidCodec::getPixels

This is a synonym for the version of getAndroidPixels that accepts
only three parameters (i.e. no AndroidOptions). It is very similar
to SkCodec::getPixels, so I think the motivation for naming the
version with options differently does not apply here.

Update the test to use a template, and delete a lot of redundant code.

Rename a variable to stop shadowing another variable.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add SkAndroidCodec::getPixels

This is a synonym for the version of getAndroidPixels that accepts
only three parameters (i.e. no AndroidOptions). It is very similar
to SkCodec::getPixels, so I think the motivation for naming the
version with options differently does not apply here.

Add comments to the header describing defaults.

Update the test to use a template, and delete a lot of redundant code.

Rename a variable to stop shadowing another variable.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-01-29 19:50:34]

https://codereview.chromium.org/1647153002/diff/1/include/codec/SkAndroidCodec.h
File include/codec/SkAndroidCodec.h (right):

https://codereview.chromium.org/1647153002/diff/1/include/codec/SkAndroidCode...
include/codec/SkAndroidCodec.h:222: *  Simplified version of getAndroidPixels()
where we supply the default AndroidOptions.
On 2016/01/29 17:05:33, reed1 wrote:
> What are the "default" options?
> What if I pass null to the first version?

Updated comments.

https://codereview.chromium.org/1647153002/diff/1/include/codec/SkAndroidCode...
include/codec/SkAndroidCodec.h:227: SkCodec::Result getAndroidPixels(const
SkImageInfo& info, void* pixels, size_t rowBytes);
On 2016/01/29 15:16:39, msarett wrote:
> Thoughts on also naming this getPixels() (not in this CL)?
> 
> I realize it's my fault that there is Android in the name.
> 
> Same question for AndroidOptions.

I'm in favor. As I understood it, you were concerned about having the same name
because they behave differently. But they are on different classes.

[reed1, 2016-01-29 19:53:27]

I have no opinion

lgtm

[scroggo, 2016-02-04 13:48:07]

The CQ bit was checked by scroggo@google.com

[scroggo, 2016-02-04 13:48:08]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1647153002/#ps40001
(title: "Preemptive rebase")

[commit-bot: I haz the power, 2016-02-04 13:48:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1647153002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1647153002/40001

[commit-bot: I haz the power, 2016-02-04 14:14:26]

Description was changed from

==========
Add SkAndroidCodec::getPixels

This is a synonym for the version of getAndroidPixels that accepts
only three parameters (i.e. no AndroidOptions). It is very similar
to SkCodec::getPixels, so I think the motivation for naming the
version with options differently does not apply here.

Add comments to the header describing defaults.

Update the test to use a template, and delete a lot of redundant code.

Rename a variable to stop shadowing another variable.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add SkAndroidCodec::getPixels

This is a synonym for the version of getAndroidPixels that accepts
only three parameters (i.e. no AndroidOptions). It is very similar
to SkCodec::getPixels, so I think the motivation for naming the
version with options differently does not apply here.

Add comments to the header describing defaults.

Update the test to use a template, and delete a lot of redundant code.

Rename a variable to stop shadowing another variable.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7b5e5536a18123f568afca99dc8f89019eab2c77
==========

[commit-bot: I haz the power, 2016-02-04 14:14:26]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7b5e5536a18123f568afca99dc8f89019eab2c77