Add SkAndroidCodec::getPixels

include/codec/SkAndroidCodec.h

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkAndroidCodec_DEFINED
 #define SkAndroidCodec_DEFINED
 
@@ skipping 201 matching lines @@
      *  @return Result kSuccess, or another value explaining the type of failure.
      */
     // FIXME: It's a bit redundant to name this getAndroidPixels() when this class is already
     //        called SkAndroidCodec.  On the other hand, it's may be a bit confusing to call
     //        this getPixels() when it is a slightly different API than SkCodec's getPixels().
     //        Maybe this should be decode() or decodeSubset()?
     SkCodec::Result getAndroidPixels(const SkImageInfo& info, void* pixels, size_t rowBytes,
             const AndroidOptions* options);
 
     /**
      *  Simplified version of getAndroidPixels() where we supply the default AndroidOptions.

[reed1, 2016/01/29 17:05:33]

What are the "default" options?
What if I pass null to the first version?

[scroggo, 2016/01/29 19:50:33]

Updated comments.

      *
      *  This will return an error if the info is kIndex_8_SkColorType and also will not perform
      *  any scaling or subsetting.
      */
     SkCodec::Result getAndroidPixels(const SkImageInfo& info, void* pixels, size_t rowBytes);

[msarett, 2016/01/29 15:16:39]

Thoughts on also naming this getPixels() (not in this CL)?

I realize it's my fault that there is Android in the name.

Same question for AndroidOptions.

[scroggo, 2016/01/29 19:50:33]

I'm in favor. As I understood it, you were concerned about having the same name
because they behave differently. But they are on different classes.

 
+    SkCodec::Result getPixels(const SkImageInfo& info, void* pixels, size_t rowBytes) {
+        return this->getAndroidPixels(info, pixels, rowBytes);
+    }
+
 protected:
 
     SkAndroidCodec(SkCodec*);
 
     SkCodec* codec() const { return fCodec.get(); }
 
     virtual SkISize onGetSampledDimensions(int sampleSize) const = 0;
 
     virtual bool onGetSupportedSubset(SkIRect* desiredSubset) const = 0;
 
     virtual SkCodec::Result onGetAndroidPixels(const SkImageInfo& info, void* pixels,
             size_t rowBytes, const AndroidOptions& options) = 0;
 
 private:
 
     // This will always be a reference to the info that is contained by the
     // embedded SkCodec.
     const SkImageInfo& fInfo;
 
     SkAutoTDelete<SkCodec> fCodec;
 };
 #endif // SkAndroidCodec_DEFINED