Revert of DevTools: remove V8ScriptRunner use from InjectedScript*.

Revert of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #2 id:20001 of https://codereview.chromium.org/1641933002/ )

Reason for revert:
http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started failing

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...

Reverting to see if we can get that test to pass again.

Original issue's description:
> DevTools: remove V8ScriptRunner use from InjectedScript*.
>
> BUG=580337
>
> Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
> Cr-Commit-Position: refs/heads/master@{#372020}

TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580337
Committed: https://crrev.com/718abf542ea95a35036331f3c78caf21959155dc
Cr-Commit-Position: refs/heads/master@{#372034}

[Noel Gordon, 2016-01-28 06:37:05]

Created Revert of DevTools: remove V8ScriptRunner use from InjectedScript*.

[commit-bot: I haz the power, 2016-01-28 06:37:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646803002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646803002/1

[commit-bot: I haz the power, 2016-01-28 06:38:34]

Description was changed from

==========
Revert of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #2
id:20001 of https://codereview.chromium.org/1641933002/ )

Reason for revert:
http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started
failing 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...

Reverting to see if we can get that test to pass again.

Original issue's description:
> DevTools: remove V8ScriptRunner use from InjectedScript*.
> 
> BUG=580337
> 
> Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
> Cr-Commit-Position: refs/heads/master@{#372020}

TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580337
==========

to

==========
Revert of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #2
id:20001 of https://codereview.chromium.org/1641933002/ )

Reason for revert:
http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started
failing 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...

Reverting to see if we can get that test to pass again.

Original issue's description:
> DevTools: remove V8ScriptRunner use from InjectedScript*.
> 
> BUG=580337
> 
> Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
> Cr-Commit-Position: refs/heads/master@{#372020}

TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580337
==========

[commit-bot: I haz the power, 2016-01-28 06:38:35]

Committed patchset #1 (id:1)

[Noel Gordon, 2016-01-28 06:38:56]

Description was changed from

==========
Revert of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #2
id:20001 of https://codereview.chromium.org/1641933002/ )

Reason for revert:
http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started
failing 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...

Reverting to see if we can get that test to pass again.

Original issue's description:
> DevTools: remove V8ScriptRunner use from InjectedScript*.
> 
> BUG=580337
> 
> Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
> Cr-Commit-Position: refs/heads/master@{#372020}

TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580337
==========

to

==========
Revert of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #2
id:20001 of https://codereview.chromium.org/1641933002/ )

Reason for revert:
http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started
failing 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...
Reverting to see if we can get that test to pass again.

Original issue's description:
> DevTools: remove V8ScriptRunner use from InjectedScript*.
> 
> BUG=580337
> 
> Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
> Cr-Commit-Position: refs/heads/master@{#372020}

TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580337
==========

[commit-bot: I haz the power, 2016-01-28 06:39:47]

Description was changed from

==========
Revert of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #2
id:20001 of https://codereview.chromium.org/1641933002/ )

Reason for revert:
http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started
failing 

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...
Reverting to see if we can get that test to pass again.

Original issue's description:
> DevTools: remove V8ScriptRunner use from InjectedScript*.
> 
> BUG=580337
> 
> Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
> Cr-Commit-Position: refs/heads/master@{#372020}

TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580337
==========

to

==========
Revert of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #2
id:20001 of https://codereview.chromium.org/1641933002/ )

Reason for revert:
http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started
failing

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...

Reverting to see if we can get that test to pass again.

Original issue's description:
> DevTools: remove V8ScriptRunner use from InjectedScript*.
>
> BUG=580337
>
> Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
> Cr-Commit-Position: refs/heads/master@{#372020}

TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580337

Committed: https://crrev.com/718abf542ea95a35036331f3c78caf21959155dc
Cr-Commit-Position: refs/heads/master@{#372034}
==========

[commit-bot: I haz the power, 2016-01-28 06:39:48]

Patchset 1 (id:??) landed as
https://crrev.com/718abf542ea95a35036331f3c78caf21959155dc
Cr-Commit-Position: refs/heads/master@{#372034}

[Noel Gordon, 2016-01-28 06:42:32]

On 2016/01/28 06:38:35, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1)

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...
was the failing build (if the change log didn't catch it, grrr@ web CSS ellipsis
style interworking with copy & paste and rietveld).

[pfeldman, 2016-01-28 15:42:23]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1645663004/ by pfeldman@chromium.org.

The reason for reverting is: The test you reverted it for is flaky:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...

You should mute it and file a bug..

[Noel Gordon, 2016-01-28 15:49:22]

On 2016/01/28 15:42:23, pfeldman wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1645663004/ by mailto:pfeldman@chromium.org.
> 
> The reason for reverting is: The test you reverted it for is flaky:
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...
> 
> You should mute it and file a bug..

You should maybe consider fixing the test.

[pfeldman, 2016-01-28 15:52:33]

> You should maybe consider fixing the test.

I was referring to the "Workflows" section of the
https://www.chromium.org/blink/gardening which explicitly handles this
situation.

(these tests seem to misbehave since the oilpan being enabled, we'll definitely
look into that).

[pfeldman, 2016-01-28 15:56:55]

Yep, here it is: https://code.google.com/p/chromium/issues/detail?id=575766

[Noel Gordon, 2016-01-28 16:15:48]

On 2016/01/28 15:56:55, pfeldman wrote:
> Yep, here it is: https://code.google.com/p/chromium/issues/detail?id=575766

IC, an Oilpan problem ... since Jan 8th! 

In other news we are red again:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...

pilgrim@ is the gardener, so perhaps we can add a new expectation for Oilpan for
this test.

[Noel Gordon, 2016-01-28 16:16:18]

Description was changed from

==========
Revert of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #2
id:20001 of https://codereview.chromium.org/1641933002/ )

Reason for revert:
http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started
failing

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...

Reverting to see if we can get that test to pass again.

Original issue's description:
> DevTools: remove V8ScriptRunner use from InjectedScript*.
>
> BUG=580337
>
> Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
> Cr-Commit-Position: refs/heads/master@{#372020}

TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580337

Committed: https://crrev.com/718abf542ea95a35036331f3c78caf21959155dc
Cr-Commit-Position: refs/heads/master@{#372034}
==========

to

==========
Revert of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #2
id:20001 of https://codereview.chromium.org/1641933002/ )

Reason for revert:
http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started
failing

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...

Reverting to see if we can get that test to pass again.

Original issue's description:
> DevTools: remove V8ScriptRunner use from InjectedScript*.
>
> BUG=580337
>
> Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
> Cr-Commit-Position: refs/heads/master@{#372020}

TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580337

Committed: https://crrev.com/718abf542ea95a35036331f3c78caf21959155dc
Cr-Commit-Position: refs/heads/master@{#372034}
==========

[pfeldman, 2016-01-28 16:34:49]

On 2016/01/28 16:15:48, noel gordon wrote:
> On 2016/01/28 15:56:55, pfeldman wrote:
> > Yep, here it is: https://code.google.com/p/chromium/issues/detail?id=575766
> 
> IC, an Oilpan problem ... since Jan 8th! 
> 

Could you explain you tone please?

The issue was filed against Oilpan (non-tree-closer bots) on Jan 8th. Oilpan
owners were aware of the issue, but decided to enable Oilpan on trunk this
Monday. Given the scale of Oilpan change, breakages like this are expected and
as per haraken's update they are going full speed through the issues.


Gardener's responsibility is to follow the documented workflow and I cited what
you should have done from that doc.

> In other news we are red again:
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...


And the reason is that you did a wrong thing - it is clear that randon revert
does not fix the flake and the doc suggests what you should have done to resolve
it.

> 
> pilgrim@ is the gardener, so perhaps we can add a new expectation for Oilpan
for
> this test.

I did that first thing in the morning, so he would no' need to.

[Noel Gordon, 2016-01-28 17:12:35]

On 2016/01/28 16:34:49, pfeldman wrote:
> On 2016/01/28 16:15:48, noel gordon wrote:
> > On 2016/01/28 15:56:55, pfeldman wrote:
> > > Yep, here it is:
https://code.google.com/p/chromium/issues/detail?id=575766
> > 
> > IC, an Oilpan problem ... since Jan 8th! 
> > 
> 
> Could you explain you tone please?

What I meant was, I thought a new expectation might have been submitted sometime
during Jan 8th till today to handle the flake.  

Looked to be recent issue to me, didn't find the bug reference you found.

> The issue was filed against Oilpan (non-tree-closer bots) on Jan 8th. Oilpan
> owners were aware of the issue, but decided to enable Oilpan on trunk this
> Monday. Given the scale of Oilpan change, breakages like this are expected and
> as per haraken's update they are going full speed through the issues.

Yes I have been cc-ing haraken on any thing I thought was Oilpan related.

First time I've had to garden the tree with Oilpan on.
 
> Gardener's responsibility is to follow the documented workflow and I cited
what
> you should have done from that doc.

Yes, what to do for Oilpan failures had going old skool and adding them
OilpanExpectations.

That didn't work, of course, but haraken@ mentioned were to put them now.

> > In other news we are red again:
> > 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...
>  
> And the reason is that you did a wrong thing - it is clear that randon revert
> does not fix the flake and the doc suggests what you should have done to
resolve
> it.

I mentioned in the revert log "Reverting to see if we can get that test to pass
again", aka speculative.  And I revert-revert those if I find a revert does not
fix things.  You beat to me to it, but apparently I was looking in the wrong
place :/

> > pilgrim@ is the gardener, so perhaps we can add a new expectation for Oilpan
> for
> > this test.
> 
> I did that first thing in the morning, so he would no' need to.

Thanks for that.