Update webusb_descriptors.cc to parse the new WebUSB descriptors.

Update webusb_descriptors.cc to parse the new WebUSB descriptors.

The format of WebUSB descriptors as defined by the draft specification
has changed. This patch brings Chrome up to date.

BUG=492204
Committed: https://crrev.com/2437acdda282dee93adead76ef98eaabda819e91
Cr-Commit-Position: refs/heads/master@{#372249}

[Reilly Grant (use Gerrit), 2016-01-28 02:26:16]

reillyg@chromium.org changed reviewers:
+ rockot@chromium.org

[Reilly Grant (use Gerrit), 2016-01-28 02:26:17]

Please take a look. I suggest just looking at the right side of the patch since
the descriptor format changed and so the diff is only partially meaningful.

[Ken Rockot(use gerrit already), 2016-01-28 04:15:50]

As best as I can tell without my eyes glazing over, this looks OK so LGTM.

As a general comment, webusb_descriptors.cc could use a lot of inline
documentation. It's pretty densely packed with non-obvious logic so it's hard as
a reader to A) understand what's going on and why and B) actually verify that it
does what it's supposed to.

Reading inline comments, even if they're relatively abridged compared to the
spec, would still be much nicer than trying to follow along with the spec in one
hand and the code in the other.

https://codereview.chromium.org/1646783002/diff/1/device/usb/webusb_descripto...
File device/usb/webusb_descriptors.cc (right):

https://codereview.chromium.org/1646783002/diff/1/device/usb/webusb_descripto...
device/usb/webusb_descriptors.cc:66: if (length < 3 || std::distance(*it, end) <
length ||
Maybe it would be best to define constants even for these one-off values of 2,
3, etc, so they have some named meaning in code.

[Reilly Grant (use Gerrit), 2016-01-28 21:29:48]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-01-28 21:29:48]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1646783002/#ps20001
(title: "Add more docs!")

[commit-bot: I haz the power, 2016-01-28 21:30:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646783002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646783002/20001

[commit-bot: I haz the power, 2016-01-28 22:45:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 22:45:05]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Reilly Grant (use Gerrit), 2016-01-29 01:44:30]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-01-29 01:44:30]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1646783002/#ps40001
(title: "Sometimes MSVC complains about passing size_type to BarrierClosure.")

[commit-bot: I haz the power, 2016-01-29 01:44:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646783002/40001

[commit-bot: I haz the power, 2016-01-29 01:51:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-29 01:52:39]

Description was changed from

==========
Update webusb_descriptors.cc to parse the new WebUSB descriptors.

The format of WebUSB descriptors as defined by the draft specification
has changed. This patch brings Chrome up to date.

BUG=492204
==========

to

==========
Update webusb_descriptors.cc to parse the new WebUSB descriptors.

The format of WebUSB descriptors as defined by the draft specification
has changed. This patch brings Chrome up to date.

BUG=492204

Committed: https://crrev.com/2437acdda282dee93adead76ef98eaabda819e91
Cr-Commit-Position: refs/heads/master@{#372249}
==========

[commit-bot: I haz the power, 2016-01-29 01:52:40]

Patchset 3 (id:??) landed as
https://crrev.com/2437acdda282dee93adead76ef98eaabda819e91
Cr-Commit-Position: refs/heads/master@{#372249}