Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 1642493005: Remove net/base/io_buffer.h include from usb_device_handle.h. (Closed)

Created:
4 years, 11 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 11 months ago
Reviewers:
yurys
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove net/base/io_buffer.h include from usb_device_handle.h. net::IOBuffer should be forward declared. This requires a number of source files to add their own includes where they use net::IOBuffer. BUG=None Committed: https://crrev.com/a9de0faddbb95c8c672540953a719a6eb23afe54 Cr-Commit-Position: refs/heads/master@{#371955}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/devtools/device/usb/android_usb_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_device.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_device.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_socket.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/device/usb/usb_device_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/usb/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M device/usb/mock_usb_device_handle.h View 1 chunk +1 line, -0 lines 0 comments Download
M device/usb/usb_device_handle.h View 1 chunk +5 lines, -2 lines 0 comments Download
M device/usb/usb_device_handle_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/usb/usb_device_handle_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/usb/usb_service_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 11 months ago (2016-01-27 23:44:25 UTC) #2
yurys
lgtm
4 years, 11 months ago (2016-01-28 01:15:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642493005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642493005/20001
4 years, 11 months ago (2016-01-28 01:25:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 11 months ago (2016-01-28 01:38:08 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 02:05:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9de0faddbb95c8c672540953a719a6eb23afe54
Cr-Commit-Position: refs/heads/master@{#371955}

Powered by Google App Engine
This is Rietveld 408576698