Make InsertListCommand::unlififyParagraph() to do nothing when it applied to uneditable element

Make insert{Un}OrderedListCommand/insertUnorderedListCommand to do nothing for uneditable

This patch makes |InsertListCommand::doApplyForSingleParagraph()| to check
whether parent of list element which will be switch to another list type or
unlistify, editable or not. If it is uneditable, we do nothing, because we
can't modify uneditable element.

Without this patch, we hit assertion in |InsertNodeBeforeCommand| constructor.

BUG=547705
TEST=LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html

Committed: https://crrev.com/4ee4fc6cd5de77570db3291353656dabb3b2bdb7
Cr-Commit-Position: refs/heads/master@{#372302}

[yosin_UTC9, 2016-01-28 07:45:49]

Description was changed from

==========
sim# Enter a description of the change.
2016-01-28T16:39:01

BUG=547705
TEST=LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html
==========

to

==========
Make InsertListCommand::unlififyParagraph() to do nothing when it applied to
uneditable element


This patch makes |InsertListCommand::unlififyParagraph()| to check whether
parent of list element to unlistify is editable or not. If it is uneditable,
|unlififyParagraph()| does nothing.

BUG=547705
TEST=LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html
==========

[yosin_UTC9, 2016-01-28 07:46:45]

Description was changed from

==========
Make InsertListCommand::unlififyParagraph() to do nothing when it applied to
uneditable element


This patch makes |InsertListCommand::unlififyParagraph()| to check whether
parent of list element to unlistify is editable or not. If it is uneditable,
|unlififyParagraph()| does nothing.

BUG=547705
TEST=LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html
==========

to

==========
Make InsertListCommand::unlififyParagraph() to do nothing when it applied to
uneditable element


This patch makes |InsertListCommand::unlififyParagraph()| to check whether
parent of list element to unlistify is editable or not. If it is uneditable,
|unlififyParagraph()| does nothing.

Without this patch, we hit assertion in |InsertNodeBeforeCommand| constructor.

BUG=547705
TEST=LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html
==========

[yosin_UTC9, 2016-01-28 07:46:49]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-28 07:47:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646673003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646673003/1

[commit-bot: I haz the power, 2016-01-28 09:06:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 09:06:05]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yosin_UTC9, 2016-01-28 09:13:38]

yosin@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, tkent@chromium.org, xiaochengh@chromium.org,
yoichio@chromium.org

[yosin_UTC9, 2016-01-28 09:13:38]

PTAL

[tkent, 2016-01-29 00:11:16]

Can we improve enclosingList, fixOrphanedListChild, or mergeWithNeighboringLists
so that they return only acceptable list elements, instead of rejecting
unexpected list element in unlistifyParagraph?

[yosin_UTC9, 2016-01-29 02:12:55]

Description was changed from

==========
Make InsertListCommand::unlififyParagraph() to do nothing when it applied to
uneditable element


This patch makes |InsertListCommand::unlififyParagraph()| to check whether
parent of list element to unlistify is editable or not. If it is uneditable,
|unlififyParagraph()| does nothing.

Without this patch, we hit assertion in |InsertNodeBeforeCommand| constructor.

BUG=547705
TEST=LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html
==========

to

==========
Make insert{Un}OrderedListCommand/insertUnorderedListCommand to do nothing for
uneditable

This patch makes |InsertListCommand::doApplyForSingleParagraph()| to check
whether parent of list element which will be switch to another list type or
unlistify, editable or not. If it is uneditable, we do nothing, because we
can't modify uneditable element.

Without this patch, we hit assertion in |InsertNodeBeforeCommand| constructor.

BUG=547705
TEST=LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html
==========

[yosin_UTC9, 2016-01-29 02:17:19]

PTAL


>Can we improve enclosingList, fixOrphanedListChild, or
mergeWithNeighboringLists so that they return only acceptable list elements,
instead of rejecting unexpected list element in unlistifyParagraph?

Here is possible improvements of them. They aren't relevant this crash. So, I
postpone them.

enclosingList(); check "display" property rather than tag name. I think we leave
this function independent from editability.

fixOrphanedListChild(); No need to change except for inserting
ASSERT(listChild->parentNode()->hasEditableStyle()). In current code, it is
checked before calling this.


mergeWithNeighboringLists(); we should check editability of merge destination
list element.

[yosin_UTC9, 2016-01-29 02:17:38]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 02:18:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646673003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646673003/20001

[tkent, 2016-01-29 02:24:07]

lgtm

[yosin_UTC9, 2016-01-29 02:40:37]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2016-01-29 02:40:43]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-01-29 02:41:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646673003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646673003/20001

[commit-bot: I haz the power, 2016-01-29 06:05:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 06:05:18]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yosin_UTC9, 2016-01-29 06:17:07]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-01-29 06:17:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1646673003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1646673003/20001

[commit-bot: I haz the power, 2016-01-29 07:36:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-29 07:38:20]

Description was changed from

==========
Make insert{Un}OrderedListCommand/insertUnorderedListCommand to do nothing for
uneditable

This patch makes |InsertListCommand::doApplyForSingleParagraph()| to check
whether parent of list element which will be switch to another list type or
unlistify, editable or not. If it is uneditable, we do nothing, because we
can't modify uneditable element.

Without this patch, we hit assertion in |InsertNodeBeforeCommand| constructor.

BUG=547705
TEST=LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html
==========

to

==========
Make insert{Un}OrderedListCommand/insertUnorderedListCommand to do nothing for
uneditable

This patch makes |InsertListCommand::doApplyForSingleParagraph()| to check
whether parent of list element which will be switch to another list type or
unlistify, editable or not. If it is uneditable, we do nothing, because we
can't modify uneditable element.

Without this patch, we hit assertion in |InsertNodeBeforeCommand| constructor.

BUG=547705
TEST=LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html

Committed: https://crrev.com/4ee4fc6cd5de77570db3291353656dabb3b2bdb7
Cr-Commit-Position: refs/heads/master@{#372302}
==========

[commit-bot: I haz the power, 2016-01-29 07:38:20]

Patchset 2 (id:??) landed as
https://crrev.com/4ee4fc6cd5de77570db3291353656dabb3b2bdb7
Cr-Commit-Position: refs/heads/master@{#372302}