third_party/WebKit/LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html - Issue 1646673003: Make InsertListCommand::unlififyParagraph() to do nothing when it applied to uneditable element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html

Issue 1646673003: Make InsertListCommand::unlififyParagraph() to do nothing when it applied to uneditable element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2016-01-29T11:06:31 Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html

diff --git a/third_party/WebKit/LayoutTests/editing/spelling/mark-empty-crash.html b/third_party/WebKit/LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html

similarity index 51%

copy from third_party/WebKit/LayoutTests/editing/spelling/mark-empty-crash.html

copy to third_party/WebKit/LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html

index bf49b827b40979144d226749b7e0fb87808169e0..cf605cce6095ab3e2a27a8ded53f63c48baf2d25 100644

--- a/third_party/WebKit/LayoutTests/editing/spelling/mark-empty-crash.html

+++ b/third_party/WebKit/LayoutTests/editing/execCommand/unlistify-uneditable-parent-crash.html

@@ -1,15 +1,14 @@

<!DOCTYPE html>

-<ul contenteditable>

-<li id="foo"></li>

-</ul>

+<div>

+<ol contenteditable id=sample>

+<li>foo</li>

+</ol>

+<div id="log"></div>

test(function() {

- if (!window.internals)

- return;

- internals.settings.setUnifiedTextCheckerEnabled(true);

- window.getSelection().selectAllChildren(document.getElementById('foo'));

- document.execCommand('insertParagraph');

-}, 'spelling');

+ window.getSelection().selectAllChildren(document.getElementById('sample'));

+ document.execCommand('insertOrderedList');

+}, 'insertOrderedList should not crash with uneditable parent');

</script>

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp » ('j') | no next file with comments »