components/filesystem/public/interfaces/file.mojom - Issue 1646673002: mojo filesystem: Simplify full file reading/writing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/filesystem/public/interfaces/file.mojom

Issue 1646673002: mojo filesystem: Simplify full file reading/writing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Take 2 at trying to fix compile. The release version is complaining about duplicate -1s and this is… Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/filesystem/public/interfaces/file.mojom

diff --git a/components/filesystem/public/interfaces/file.mojom b/components/filesystem/public/interfaces/file.mojom

index ec0c6fa5ead085489c1d6de30fefe448643131c2..d64c0f12339d2b94a34060fc73c0552f1640c24a 100644

--- a/components/filesystem/public/interfaces/file.mojom

+++ b/components/filesystem/public/interfaces/file.mojom

@@ -27,10 +27,6 @@ interface File {

Read(uint32 num_bytes_to_read, int64 offset, Whence whence)

=> (FileError error, array<uint8>? bytes_read);

- // Returns the entire contents of the file as an array of bytes. The mojo

- // equivalent of base::ReadFileToString().

- ReadEntireFile() => (FileError error, array<uint8>? bytes_read);

// TODO(vtl): Clarify behavior when |num_bytes_written| is less than the size

// of |bytes_to_write|.

« no previous file with comments | « components/filesystem/public/interfaces/directory.mojom ('k') | no next file » | no next file with comments »