components/filesystem/public/interfaces/directory.mojom - Issue 1646673002: mojo filesystem: Simplify full file reading/writing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/filesystem/public/interfaces/directory.mojom

Issue 1646673002: mojo filesystem: Simplify full file reading/writing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Take 2 at trying to fix compile. The release version is complaining about duplicate -1s and this is… Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/filesystem/public/cpp/prefs/filesystem_json_pref_store.cc ('k') | components/filesystem/public/interfaces/file.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/filesystem/public/interfaces/directory.mojom

diff --git a/components/filesystem/public/interfaces/directory.mojom b/components/filesystem/public/interfaces/directory.mojom

index bd5aba4dceebf1c57dc3442452b8499d82d7c69e..4d521aea2542c06d5aeb5e3f19c527f159b8b2b2 100644

--- a/components/filesystem/public/interfaces/directory.mojom

+++ b/components/filesystem/public/interfaces/directory.mojom

@@ -52,6 +52,12 @@ interface Directory {

// fsync()/FlushFileBuffers().

Flush() => (FileError error);

+ // Reads the contents of an entire file.

+ ReadEntireFile(string path) => (FileError error, array<uint8> data);

+ // Writes |data| to |path|, overwriting the file if it already exists.

+ WriteFile(string path, array<uint8> data) => (FileError error);

// TODO(vtl): directory "streaming"?

// TODO(vtl): "make root" (i.e., prevent cd-ing, etc., to parent); note that

// this would require a much more complicated implementation (e.g., it needs