Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1646623006: Fix compilation errors on Android and Windows (Closed)

Created:
4 years, 10 months ago by jungshik at Google
Modified:
4 years, 10 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix compilation errors on Android and Windows MSVC complains about '*/* foobar */'. Add a space between '*' and '/'. ICU uses a deprecated API internally and '-Wno-deprecated...' flag has to be turned on on Android as well as on Linux. Do not use ''-Wno-reorder' any more because it's not necessary. BUG=575007 TEST=Once rolled, Android and Windows build go through. R=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/fcf424f3cc600145bf9fe5c11c50849131e5a6d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M icu.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M patches/vscomp.patch View 1 chunk +13 lines, -0 lines 0 comments Download
M source/i18n/dtfmtsym.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
jungshik at Google
PTAL. Thanks
4 years, 10 months ago (2016-01-29 23:43:46 UTC) #4
Nico
lgtm
4 years, 10 months ago (2016-01-29 23:53:25 UTC) #5
jungshik at Google
4 years, 10 months ago (2016-02-02 07:15:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fcf424f3cc600145bf9fe5c11c50849131e5a6d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698