Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: README.chromium

Issue 1646623006: Fix compilation errors on Android and Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | icu.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.chromium
diff --git a/README.chromium b/README.chromium
index d1f0fa0d08bb24f4abe2a66a2f8ad0459f73ee32..a8df219c5d5daeab0ab50425f3e6420d5ce8c0b4 100644
--- a/README.chromium
+++ b/README.chromium
@@ -265,6 +265,7 @@ D. Local Modifications
- patches/vscomp.patch for building with Visual Studio on Windows.
a. do not use WINDOWS_LOCALE_API in locmap.c
b. do not redefine stringpiece::npos
+ c. fix http://bugs.icu-project.org/trac/ticket/12129 (C4138 warning)
- patches/data.build.patch :
Remove unnecessary resources : unames, collator rule source
« no previous file with comments | « BUILD.gn ('k') | icu.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698