Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 1646603004: Move scroll event handlers from layer to layer tree view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_cc_listeners
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 return m_popup->m_layerTreeView->setHaveWheelEventHandlers(haveEvent Handlers); 174 return m_popup->m_layerTreeView->setHaveWheelEventHandlers(haveEvent Handlers);
175 } 175 }
176 176
177 bool haveWheelEventHandlers() const override 177 bool haveWheelEventHandlers() const override
178 { 178 {
179 if (m_popup->m_layerTreeView) 179 if (m_popup->m_layerTreeView)
180 return m_popup->m_layerTreeView->haveWheelEventHandlers(); 180 return m_popup->m_layerTreeView->haveWheelEventHandlers();
181 return false; 181 return false;
182 } 182 }
183 183
184 void setHaveScrollEventHandlers(bool hasEventHandlers) override
185 {
186 if (m_popup->m_layerTreeView)
187 m_popup->m_layerTreeView->setHaveScrollEventHandlers(hasEventHandler s);
188 }
189
190 bool haveScrollEventHandlers() const override
191 {
192 if (m_popup->m_layerTreeView)
193 return m_popup->m_layerTreeView->haveScrollEventHandlers();
194 return false;
195 }
196
184 void setTouchAction(TouchAction touchAction) override 197 void setTouchAction(TouchAction touchAction) override
185 { 198 {
186 if (WebViewClient* client = m_popup->m_webView->client()) 199 if (WebViewClient* client = m_popup->m_webView->client())
187 client->setTouchAction(static_cast<WebTouchAction>(touchAction)); 200 client->setTouchAction(static_cast<WebTouchAction>(touchAction));
188 } 201 }
189 202
190 GraphicsLayerFactory* graphicsLayerFactory() const override 203 GraphicsLayerFactory* graphicsLayerFactory() const override
191 { 204 {
192 return m_popup->m_webView->graphicsLayerFactory(); 205 return m_popup->m_webView->graphicsLayerFactory();
193 } 206 }
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
558 // A WebPagePopupImpl instance usually has two references. 571 // A WebPagePopupImpl instance usually has two references.
559 // - One owned by the instance itself. It represents the visible widget. 572 // - One owned by the instance itself. It represents the visible widget.
560 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 573 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
561 // WebPagePopupImpl to close. 574 // WebPagePopupImpl to close.
562 // We need them because the closing operation is asynchronous and the widget 575 // We need them because the closing operation is asynchronous and the widget
563 // can be closed while the WebViewImpl is unaware of it. 576 // can be closed while the WebViewImpl is unaware of it.
564 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 577 return adoptRef(new WebPagePopupImpl(client)).leakRef();
565 } 578 }
566 579
567 } // namespace blink 580 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.cpp ('k') | third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698