Turn disallowed URL patterns such as <all_urls> for externally_connectable into

chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc

Index: chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc
diff --git a/chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc b/chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc
index c2da186b59b5bdb8da8b2830b38bb58aa4720225..fad12dcf2051ff72ec4784317a21caa0b8d38d5d 100644
--- a/chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc
+++ b/chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc
@@ -218,7 +218,7 @@ TEST_F(ExternallyConnectableTest, ErrorNoAllURLs) {
           "externally_connectable_error_all_urls.json",
           ErrorUtils::FormatErrorMessage(errors::kErrorWildcardHostsNotAllowed,
                                          "<all_urls>")),
-      EXPECT_TYPE_ERROR);
+      EXPECT_TYPE_WARNING);

[Yoyo Zhou, 2013/06/10 23:51:06]

Does this test that the wildcard host patterns were actually ignored?

[not at google - send to devlin, 2013/06/11 01:55:23]

Good point. Done. This required more changes than expected, so PTAL.

 }
 
 TEST_F(ExternallyConnectableTest, ErrorWildcardHost) {
@@ -227,7 +227,7 @@ TEST_F(ExternallyConnectableTest, ErrorWildcardHost) {
           "externally_connectable_error_wildcard_host.json",
           ErrorUtils::FormatErrorMessage(errors::kErrorWildcardHostsNotAllowed,
                                          "http://*/*")),
-      EXPECT_TYPE_ERROR);
+      EXPECT_TYPE_WARNING);
 }
 
 TEST_F(ExternallyConnectableTest, ErrorNoTLD) {
@@ -238,7 +238,7 @@ TEST_F(ExternallyConnectableTest, ErrorNoTLD) {
               errors::kErrorTopLevelDomainsNotAllowed,
               "co.uk",
               "http://*.co.uk/*")),
-      EXPECT_TYPE_ERROR);
+      EXPECT_TYPE_WARNING);
 }
 
 TEST_F(ExternallyConnectableTest, ErrorNoEffectiveTLD) {
@@ -249,7 +249,7 @@ TEST_F(ExternallyConnectableTest, ErrorNoEffectiveTLD) {
               errors::kErrorTopLevelDomainsNotAllowed,
               "appspot.com",
               "http://*.appspot.com/*")),
-      EXPECT_TYPE_ERROR);
+      EXPECT_TYPE_WARNING);
 }
 
 TEST_F(ExternallyConnectableTest, ErrorUnknownTLD) {
@@ -260,7 +260,7 @@ TEST_F(ExternallyConnectableTest, ErrorUnknownTLD) {
               errors::kErrorTopLevelDomainsNotAllowed,
               "notatld",
               "http://*.notatld/*")),
-      EXPECT_TYPE_ERROR);
+      EXPECT_TYPE_WARNING);
 }
 
 }  // namespace extensions