Turn disallowed URL patterns such as <all_urls> for externally_connectable into

chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/common/extensions/features/feature.h"
 #include "chrome/common/extensions/manifest_handlers/externally_connectable.h"
 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
@@ skipping 200 matching lines @@
                                               "www.yahoo.com")),
       EXPECT_TYPE_ERROR);
 }
 
 TEST_F(ExternallyConnectableTest, ErrorNoAllURLs) {
   RunTestcase(
       Testcase(
           "externally_connectable_error_all_urls.json",
           ErrorUtils::FormatErrorMessage(errors::kErrorWildcardHostsNotAllowed,
                                          "<all_urls>")),
-      EXPECT_TYPE_ERROR);
+      EXPECT_TYPE_WARNING);

[Yoyo Zhou, 2013/06/10 23:51:06]

Does this test that the wildcard host patterns were actually ignored?

[not at google - send to devlin, 2013/06/11 01:55:23]

Good point. Done. This required more changes than expected, so PTAL.

 }
 
 TEST_F(ExternallyConnectableTest, ErrorWildcardHost) {
   RunTestcase(
       Testcase(
           "externally_connectable_error_wildcard_host.json",
           ErrorUtils::FormatErrorMessage(errors::kErrorWildcardHostsNotAllowed,
                                          "http://*/*")),
-      EXPECT_TYPE_ERROR);
+      EXPECT_TYPE_WARNING);
 }
 
 TEST_F(ExternallyConnectableTest, ErrorNoTLD) {
   RunTestcase(
       Testcase(
           "externally_connectable_error_tld.json",
           ErrorUtils::FormatErrorMessage(
               errors::kErrorTopLevelDomainsNotAllowed,
               "co.uk",
               "http://*.co.uk/*")),
-      EXPECT_TYPE_ERROR);
+      EXPECT_TYPE_WARNING);
 }
 
 TEST_F(ExternallyConnectableTest, ErrorNoEffectiveTLD) {
   RunTestcase(
       Testcase(
           "externally_connectable_error_effective_tld.json",
           ErrorUtils::FormatErrorMessage(
               errors::kErrorTopLevelDomainsNotAllowed,
               "appspot.com",
               "http://*.appspot.com/*")),
-      EXPECT_TYPE_ERROR);
+      EXPECT_TYPE_WARNING);
 }
 
 TEST_F(ExternallyConnectableTest, ErrorUnknownTLD) {
   RunTestcase(
       Testcase(
           "externally_connectable_error_unknown_tld.json",
           ErrorUtils::FormatErrorMessage(
               errors::kErrorTopLevelDomainsNotAllowed,
               "notatld",
               "http://*.notatld/*")),
-      EXPECT_TYPE_ERROR);
+      EXPECT_TYPE_WARNING);
 }
 
 }  // namespace extensions