Turn disallowed URL patterns such as <all_urls> for externally_connectable into

Turn disallowed URL patterns such as <all_urls> for externally_connectable into
warnings not errors. This is for forward compatibility, if we ever lift the
no-eTLD-wildcard restriction.

Malformed URLs remain errors.

BUG=55316
R=yoz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205514

[Yoyo Zhou, 2013-06-10 23:51:06]

LGTM

https://codereview.chromium.org/16464004/diff/5001/chrome/common/extensions/m...
File
chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc
(right):

https://codereview.chromium.org/16464004/diff/5001/chrome/common/extensions/m...
chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc:221:
EXPECT_TYPE_WARNING);
Does this test that the wildcard host patterns were actually ignored?

[not at google - send to devlin, 2013-06-11 01:55:23]

https://codereview.chromium.org/16464004/diff/5001/chrome/common/extensions/m...
File
chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc
(right):

https://codereview.chromium.org/16464004/diff/5001/chrome/common/extensions/m...
chrome/common/extensions/manifest_handlers/externally_connectable_unittest.cc:221:
EXPECT_TYPE_WARNING);
On 2013/06/10 23:51:06, Yoyo Zhou wrote:
> Does this test that the wildcard host patterns were actually ignored?

Good point. Done. This required more changes than expected, so PTAL.

[not at google - send to devlin, 2013-06-11 02:02:00]

I'm leaving now so complain if you don't like it :)

[commit-bot: I haz the power, 2013-06-11 02:02:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/16464004/17001

[commit-bot: I haz the power, 2013-06-11 12:50:56]

Change committed as 205514