Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1688)

Issue 1645923002: RenderViewTest: really drain the event loop before shutting down Blink. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RenderViewTest: really drain the event loop before shutting down Blink. And with that in place, undo the partial fix by r371169. R=haraken,jochen BUG=581948 NOTRY=true Committed: https://crrev.com/08cd68e7f106967cc0e510e803db8e4dcdaf5a65 Cr-Commit-Position: refs/heads/master@{#372088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M content/public/test/render_view_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 3 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
haraken
LGTM
4 years, 10 months ago (2016-01-28 10:55:06 UTC) #2
sof
please take a look. well, haraken@ already has - jochen@ for owner review.
4 years, 10 months ago (2016-01-28 12:50:32 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-01-28 12:53:13 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645923002/1
4 years, 10 months ago (2016-01-28 12:53:40 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/172746)
4 years, 10 months ago (2016-01-28 15:22:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645923002/1
4 years, 10 months ago (2016-01-28 15:28:07 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 15:35:01 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 15:36:16 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08cd68e7f106967cc0e510e803db8e4dcdaf5a65
Cr-Commit-Position: refs/heads/master@{#372088}

Powered by Google App Engine
This is Rietveld 408576698