Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2397)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1645923002: RenderViewTest: really drain the event loop before shutting down Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index 868be6fa4836a755b62721625000590bc6a90d60..43e9a438679cf11e68419357bed574d59b56940e 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -59,7 +59,6 @@
#include "third_party/WebKit/public/platform/WebURLResponse.h"
#include "third_party/WebKit/public/web/WebDataSource.h"
#include "third_party/WebKit/public/web/WebDeviceEmulationParams.h"
-#include "third_party/WebKit/public/web/WebHeap.h"
#include "third_party/WebKit/public/web/WebHistoryCommitType.h"
#include "third_party/WebKit/public/web/WebHistoryItem.h"
#include "third_party/WebKit/public/web/WebLocalFrame.h"
@@ -88,7 +87,6 @@
#include "url/url_constants.h"
using blink::WebFrame;
-using blink::WebHeap;
using blink::WebInputEvent;
using blink::WebLocalFrame;
using blink::WebMouseEvent;
@@ -173,13 +171,6 @@ class RenderViewImplTest : public RenderViewTest {
RenderViewTest::SetUp();
}
- // To avoid flaky leak reports, insist on GCing
- // Blink upon shutdown to clear out garbage.
- void TearDown() override {
- WebHeap::collectGarbageForTesting();
- RenderViewTest::TearDown();
- }
-
RenderViewImpl* view() {
return static_cast<RenderViewImpl*>(view_);
}
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698