tools/clang/blink_gc_plugin/CheckTraceVisitor.h - Issue 1645763004: blink_gc_plugin: Make RecordInfo::Get{Fields,Bases} return deterministic order

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/CheckTraceVisitor.h

Issue 1645763004: blink_gc_plugin: Make RecordInfo::Get{Fields,Bases} return deterministic order (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/CheckFinalizerVisitor.cpp ('k') | tools/clang/blink_gc_plugin/CheckTraceVisitor.cpp » ('j') | tools/clang/blink_gc_plugin/RecordInfo.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/CheckTraceVisitor.h

diff --git a/tools/clang/blink_gc_plugin/CheckTraceVisitor.h b/tools/clang/blink_gc_plugin/CheckTraceVisitor.h

index 580a6fba99bb1a2ad931df579763d05ba0e273ab..ea0edf4f66b830df1c54df403371b36ffebd45d5 100644

--- a/tools/clang/blink_gc_plugin/CheckTraceVisitor.h

+++ b/tools/clang/blink_gc_plugin/CheckTraceVisitor.h

@@ -46,7 +46,7 @@ class CheckTraceVisitor : public clang::RecursiveASTVisitor<CheckTraceVisitor> {

bool IsWeakCallback() const;

- void MarkTraced(RecordInfo::Fields::iterator it);

+ void MarkTraced(RecordInfo::Field& field);

void FoundField(clang::FieldDecl* field);

void MarkAllWeakMembersTraced();