Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/clang/blink_gc_plugin/CheckFinalizerVisitor.cpp

Issue 1645763004: blink_gc_plugin: Make RecordInfo::Get{Fields,Bases} return deterministic order (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/CheckFinalizerVisitor.cpp
diff --git a/tools/clang/blink_gc_plugin/CheckFinalizerVisitor.cpp b/tools/clang/blink_gc_plugin/CheckFinalizerVisitor.cpp
index f0a9bf3dba0a15198331c5a862c8fcfefceed212..a1f5bc1a893e33f964a8ae4e64f989090a49f413 100644
--- a/tools/clang/blink_gc_plugin/CheckFinalizerVisitor.cpp
+++ b/tools/clang/blink_gc_plugin/CheckFinalizerVisitor.cpp
@@ -107,8 +107,7 @@ bool CheckFinalizerVisitor::VisitMemberExpr(MemberExpr* member) {
if (!info)
return true;
- RecordInfo::Fields::iterator it = info->GetFields().find(field);
- if (it == info->GetFields().end())
+ if (!info->HasField(field))
return true;
if (seen_members_.find(member) != seen_members_.end())
@@ -116,9 +115,9 @@ bool CheckFinalizerVisitor::VisitMemberExpr(MemberExpr* member) {
bool as_eagerly_finalized = false;
if (blacklist_context_ &&
- MightBeCollected(&it->second, &as_eagerly_finalized)) {
+ MightBeCollected(&info->GetField(field).second, &as_eagerly_finalized)) {
finalized_fields_.push_back(
- Error(member, as_eagerly_finalized, &it->second));
+ Error(member, as_eagerly_finalized, &info->GetField(field).second));
seen_members_.insert(member);
}
return true;

Powered by Google App Engine
This is Rietveld 408576698