[Line Layout API] Convert a few RootInlineBox uses of layoutObject()

[Line Layout API] Convert a few RootInlineBox uses of layoutObject()

Classes inside core/layout/ that need a reference to an InlineBox's
layoutObject are being converted to use lineLayoutItem() so that we can
rationalize access to the Layout tree.

There are no functional changes.

BUG=499321
Committed: https://crrev.com/2b4d3d0cf0448f270aaaf86556fd51edb39a6d5a
Cr-Commit-Position: refs/heads/master@{#371935}

[dgrogan, 2016-01-27 22:32:02]

dgrogan@chromium.org changed reviewers:
+ eae@chromium.org, leviw@chromium.org

[dgrogan, 2016-01-27 22:32:03]

Emil or Levi, could you review this?

https://codereview.chromium.org/1645753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):

https://codereview.chromium.org/1645753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:2862:
result.uniteLeft(logicalLeftSelectionGap(rootBlock, rootBlockPhysicalPosition,
offsetFromRootBlock, LineLayoutItem(const_cast<LayoutBlockFlow*>(this)),
curr->logicalLeft(), curr->logicalTop(), curr->logicalHeight(), paintInfo));
The const_cast is gross but at least there's precedent:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[eae, 2016-01-27 22:34:37]

LGTM

https://codereview.chromium.org/1645753002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):

https://codereview.chromium.org/1645753002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:2862:
result.uniteLeft(logicalLeftSelectionGap(rootBlock, rootBlockPhysicalPosition,
offsetFromRootBlock, LineLayoutItem(const_cast<LayoutBlockFlow*>(this)),
curr->logicalLeft(), curr->logicalTop(), curr->logicalHeight(), paintInfo));
On 2016/01/27 22:32:03, dgrogan wrote:
> The const_cast is gross but at least there's precedent:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Eww, that's pretty gross. We should be able to remove the selection gap code
pretty soon though so it's likely okay.

[dgrogan, 2016-01-27 22:47:19]

The CQ bit was checked by dgrogan@chromium.org

[commit-bot: I haz the power, 2016-01-27 22:47:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 22:47:43]

This CL has an open dependency (Issue 1649453002 Patch 1). Please resolve the
dependency and try again.

[dgrogan, 2016-01-27 23:08:58]

The CQ bit was checked by dgrogan@chromium.org

[dgrogan, 2016-01-27 23:08:58]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1645753002/#ps20001
(title: "without patchset dependency")

[commit-bot: I haz the power, 2016-01-27 23:10:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1645753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1645753002/20001

[commit-bot: I haz the power, 2016-01-28 00:28:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-28 00:35:21]

Description was changed from

==========
[Line Layout API] Convert a few RootInlineBox uses of layoutObject()

Classes inside core/layout/ that need a reference to an InlineBox's
layoutObject are being converted to use lineLayoutItem() so that we can
rationalize access to the Layout tree.

There are no functional changes.

BUG=499321
==========

to

==========
[Line Layout API] Convert a few RootInlineBox uses of layoutObject()

Classes inside core/layout/ that need a reference to an InlineBox's
layoutObject are being converted to use lineLayoutItem() so that we can
rationalize access to the Layout tree.

There are no functional changes.

BUG=499321

Committed: https://crrev.com/2b4d3d0cf0448f270aaaf86556fd51edb39a6d5a
Cr-Commit-Position: refs/heads/master@{#371935}
==========

[commit-bot: I haz the power, 2016-01-28 00:35:22]

Patchset 2 (id:??) landed as
https://crrev.com/2b4d3d0cf0448f270aaaf86556fd51edb39a6d5a
Cr-Commit-Position: refs/heads/master@{#371935}