Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1645663004: Reland of DevTools: remove V8ScriptRunner use from InjectedScript*. (Closed)

Created:
4 years, 10 months ago by pfeldman
Modified:
4 years, 10 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #1 id:1 of https://codereview.chromium.org/1646803002/ ) Reason for revert: The test you reverted it for is flaky: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http/tests/inspector/resource-tree/resource-tree-non-unique-url.html You should mute it and file a bug. Original issue's description: > Revert of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #2 id:20001 of https://codereview.chromium.org/1641933002/ ) > > Reason for revert: > http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started failing > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui... > > Reverting to see if we can get that test to pass again. > > Original issue's description: > > DevTools: remove V8ScriptRunner use from InjectedScript*. > > > > BUG=580337 > > > > Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb > > Cr-Commit-Position: refs/heads/master@{#372020} > > TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=580337 > > Committed: https://crrev.com/718abf542ea95a35036331f3c78caf21959155dc > Cr-Commit-Position: refs/heads/master@{#372034} TBR=dgozman@chromium.org,jochen@chromium.org,noel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=580337 Committed: https://crrev.com/cc8396abc0b835d619818a503032f70b71464d71 Cr-Commit-Position: refs/heads/master@{#372090}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
pfeldman
Created Reland of DevTools: remove V8ScriptRunner use from InjectedScript*.
4 years, 10 months ago (2016-01-28 15:42:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645663004/1
4 years, 10 months ago (2016-01-28 15:43:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 15:45:23 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 15:46:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc8396abc0b835d619818a503032f70b71464d71
Cr-Commit-Position: refs/heads/master@{#372090}

Powered by Google App Engine
This is Rietveld 408576698