DescriptionReland of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #1 id:1 of https://codereview.chromium.org/1646803002/ )
Reason for revert:
The test you reverted it for is flaky: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http/tests/inspector/resource-tree/resource-tree-non-unique-url.html
You should mute it and file a bug.
Original issue's description:
> Revert of DevTools: remove V8ScriptRunner use from InjectedScript*. (patchset #2 id:20001 of https://codereview.chromium.org/1641933002/ )
>
> Reason for revert:
> http/tests/inspector/resource-tree/resource-tree-non-unique-url.html started failing
>
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%2032/bui...
>
> Reverting to see if we can get that test to pass again.
>
> Original issue's description:
> > DevTools: remove V8ScriptRunner use from InjectedScript*.
> >
> > BUG=580337
> >
> > Committed: https://crrev.com/ec279b9d63c3a96d237495967faba97be76597eb
> > Cr-Commit-Position: refs/heads/master@{#372020}
>
> TBR=dgozman@chromium.org,jochen@chromium.org,pfeldman@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=580337
>
> Committed: https://crrev.com/718abf542ea95a35036331f3c78caf21959155dc
> Cr-Commit-Position: refs/heads/master@{#372034}
TBR=dgozman@chromium.org,jochen@chromium.org,noel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=580337
Committed: https://crrev.com/cc8396abc0b835d619818a503032f70b71464d71
Cr-Commit-Position: refs/heads/master@{#372090}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|