third_party/WebKit/Source/core/inspector/ThreadDebugger.h - Issue 1645663004: Reland of DevTools: remove V8ScriptRunner use from InjectedScript*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

Issue 1645663004: Reland of DevTools: remove V8ScriptRunner use from InjectedScript*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InjectedScriptNative.cpp ('k') | third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

index e6b79ab276d80e2e2514cfae487130cdae1fd456..7338a77441a6e835f97943ab3fa9d09bd3d55bda 100644

--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h

@@ -23,9 +23,10 @@

~ThreadDebugger() override;

// V8DebuggerClient implementation.

- v8::Local<v8::Object> compileDebuggerScript() override;

void eventListeners(v8::Local<v8::Value>, EventListenerInfoMap&) override;

+ v8::MaybeLocal<v8::Value> compileAndRunInternalScript(const String& script) override;

v8::MaybeLocal<v8::Value> callFunction(v8::Local<v8::Function>, v8::Local<v8::Context>, v8::Local<v8::Value> receiver, int argc, v8::Local<v8::Value> info[]) override;

+ v8::MaybeLocal<v8::Value> callInternalFunction(v8::Local<v8::Function>, v8::Local<v8::Value> receiver, int argc, v8::Local<v8::Value> info[]) override;

V8Debugger* debugger() const { return m_debugger.get(); }