Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1645573003: Exempt Cast ozone from log spam presubmit check (Closed)

Created:
4 years, 11 months ago by halliwell
Modified:
4 years, 10 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exempt Cast ozone from log spam presubmit check ui/ozone/platform/cast is only built in chromecast builds, should be treated the same way as chromecast/ (it's only under ui/ozone as a convenience to ozone platform build logic). BUG= Committed: https://crrev.com/f7fc61c6253549d1e2a411c0ad08fe564aa420ce Cr-Commit-Position: refs/heads/master@{#372114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
halliwell
4 years, 11 months ago (2016-01-27 16:17:04 UTC) #3
Paweł Hajdan Jr.
LGTM
4 years, 10 months ago (2016-01-28 16:56:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645573003/1
4 years, 10 months ago (2016-01-28 16:58:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 17:18:55 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 17:19:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7fc61c6253549d1e2a411c0ad08fe564aa420ce
Cr-Commit-Position: refs/heads/master@{#372114}

Powered by Google App Engine
This is Rietveld 408576698